This repository has been archived by the owner on May 4, 2024. It is now read-only.
Adds a lookup for type files when generating the package.json #92
+172
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype files for the package and add that information to the package if so
orta
commented
Jul 15, 2020
read-json.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| /** @type {import("fs")} */ | |||
There was a problem hiding this comment.
I can totally drop this, but it finalizes the auto-complete in the file
|
We concluded in the design meeting that it needed support for the upcoming-but-kinda-here-now-ish esmodule syntax - so I've added tests for those too. Should be good to go now 👍 |
|
@orta I re-added the RFC to the agenda so that it can be discussed at the next RFC meeting. I don't know if there's more that needed to be done here (I don't think there was but wanted to be sure), and hope to get an ok to move forward on this. I resolved the merge conflict, but linting is going to need to be fixed. |
wraithgar
reviewed
Aug 25, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
This PR will fill the
typesandflowfield when TS/Flow would have inferred support for a package based on their corresponding file system structure.References
The long-form discussion is npm/rfcs#126 - I'm making it a draft to give a chance for the rest of the TS team to discuss at our language design meeting on Friday.