fix: clean up npm object #7416
Merged
fix: clean up npm object #7416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft till CI passes. |
wraithgar
commented
Apr 25, 2024
wraithgar
commented
Apr 25, 2024
wraithgar
force-pushed
the
gar/npm-cleanup
branch
4 times, most recently
from
c6c001e
to
aba868d
Compare
Removed all the setters, they were dangerous and not the right way to set those values. Tweaked `this.#init` so it always returns an object so the coerce in `this.load` didn't need to happen.
wraithgar
force-pushed
the
gar/npm-cleanup
branch
from
aba868d
to
891e91d
Compare
lukekarrys
approved these changes
Apr 25, 2024
Merged
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all the setters, they were dangerous and not the right way to
set those values.
Tweaked
this.#initso it always returns an object so the coerce inthis.loaddidn't need to happen.