Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show more information during publish dry-run #4726

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Conversation

lukekarrys
Copy link
Contributor

Fixes #4317

@lukekarrys lukekarrys requested a review from a team as a code owner April 11, 2022 05:21
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@npm-robot
Copy link
Contributor

npm-robot commented Apr 11, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 63.650 ±3.63 32.835 ±0.08 19.490 ±0.17 21.947 ±0.63 3.342 ±0.03 3.342 ±0.01 2.712 ±0.10 12.431 ±0.02 2.644 ±0.00 3.781 ±0.06
#4726 57.609 ±4.49 32.608 ±0.04 30.497 ±15.60 22.086 ±0.56 3.329 ±0.03 3.343 ±0.00 2.682 ±0.02 12.552 ±0.18 2.680 ±0.02 3.929 ±0.18
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 38.981 ±1.69 25.587 ±0.06 14.355 ±0.09 15.482 ±0.30 3.013 ±0.05 3.110 ±0.02 2.679 ±0.06 9.395 ±0.00 2.550 ±0.02 3.469 ±0.02
#4726 39.080 ±0.30 25.650 ±0.09 14.403 ±0.11 15.396 ±0.01 3.101 ±0.06 3.054 ±0.01 2.770 ±0.17 9.571 ±0.26 2.528 ±0.00 3.509 ±0.17

@wraithgar
Copy link
Member

Dry-run not checking credentials was an intentional thing, to keep compatibility with npm6 #2422

lib/commands/publish.js Outdated Show resolved Hide resolved
@lukekarrys
Copy link
Contributor Author

❯ node . publish --dry-run 
...
npm notice bundled deps:  195                                     
npm notice bundled files: 0                                       
npm notice own files:     1752                                    
npm notice total files:   1752                                    
npm notice 
npm notice Publishing to https://registry.npmjs.org/ (dry-run)
+ npm@8.6.0
node . publish --dry-run --registry=https://npm.pkg.github.com
...
npm notice bundled deps:  195                                     
npm notice bundled files: 0                                       
npm notice own files:     1752                                    
npm notice total files:   1752                                    
npm notice 
npm WARN This command requires you to be logged in to https://npm.pkg.github.com/ (dry-run)
npm notice Publishing to https://npm.pkg.github.com/ (dry-run)
+ npm@8.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm registry not showed on publish --dry-run
5 participants