Skip to content

Commit

Permalink
prune: Fix bug where prune --production would remove dev deps from th…
Browse files Browse the repository at this point in the history 
…e lock file
  • Loading branch information
@iarna
iarna committed Feb 1, 2018
1 parent 3b305ee commit cec5be5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/prune.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,4 @@ Pruner.prototype.loadAllDepsIntoIdealTree = function (cb) {

Pruner.prototype.runPreinstallTopLevelLifecycles = function (cb) { cb() }
Pruner.prototype.runPostinstallTopLevelLifecycles = function (cb) { cb() }
Pruner.prototype.saveToDependencies = function (cb) { cb() }

1 comment on commit cec5be5

@bcomnes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some issues with shrinkwrapd packages installed as global packages where their devDeps listed in the shrinkwrap file get installed (even though they arn't needed in that context).

The change broke the ability to use prune to create devDep free shrinkwraps. I reverted and discussed more in #166

Please sign in to comment.