Skip to content

Commit

Permalink
fixup! fix: prefer fs/promises over promisify
Browse files Browse the repository at this point in the history
  • Loading branch information
lukekarrys committed Apr 23, 2024
1 parent d7f4fd9 commit ae83cb3
Show file tree
Hide file tree
Showing 10 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion workspaces/arborist/lib/arborist/build-ideal-tree.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const realpath = require('../../lib/realpath.js')
const { resolve, dirname } = require('path')
const treeCheck = require('../tree-check.js')
const { readdirScoped } = require('@npmcli/fs')
const { lstat, readlink } = require('node:fs/promises')
const { lstat, readlink } = require('fs/promises')
const { depth } = require('treeverse')
const { log, time } = require('proc-log')
const { redact } = require('@npmcli/redact')
Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/lib/arborist/reify.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const {
mkdir,
rm,
symlink,
} = require('node:fs/promises')
} = require('fs/promises')
const { moveFile } = require('@npmcli/fs')
const PackageJson = require('@npmcli/package-json')
const packageContents = require('@npmcli/installed-package-contents')
Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/lib/realpath.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// built-in fs.realpath, because we only care about symbolic links,
// so we can handle many fewer edge cases.

const { lstat, readlink } = require('node:fs/promises')
const { lstat, readlink } = require('fs/promises')
const { resolve, basename, dirname } = require('path')

const realpathCached = (path, rpcache, stcache, depth) => {
Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/lib/shrinkwrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const {
rm,
stat,
writeFile,
} = require('node:fs/promises')
} = require('fs/promises')

const { resolve, basename, relative } = require('path')
const specFromLock = require('./spec-from-lock.js')
Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/scripts/benchmark.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ process.env.ARBORIST_DEBUG = '0'

const { Suite } = require('benchmark')
const { relative, resolve } = require('path')
const { mkdir, rm } = require('node:fs/promises')
const { mkdir, rm } = require('fs/promises')
const { execSync } = require('child_process')
const { linkSync, writeFileSync, readdirSync } = require('fs')
const registryServer = require('../test/fixtures/server.js')
Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/scripts/benchmark/load-actual.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const Arborist = require('../..')
const { resolve, basename } = require('path')
const { writeFileSync } = require('fs')
const { mkdir, rm } = require('node:fs/promises')
const { mkdir, rm } = require('fs/promises')

const dir = resolve(__dirname, basename(__filename, '.js'))

Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/scripts/benchmark/reify.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const Arborist = require('../..')
const { resolve, basename } = require('path')
const { writeFileSync, rmSync } = require('fs')
const { mkdir } = require('node:fs/promises')
const { mkdir } = require('fs/promises')
const dir = resolve(__dirname, basename(__filename, '.js'))

// these are not arbitrary, the empty/full and no-* bits matter
Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/test/arborist/pruner.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ t.test('prune with lockfile omit dev', async t => {
})

t.test('prune omit dev with bins', async t => {
const { readdir } = require('node:fs/promises')
const { readdir } = require('fs/promises')
const { statSync, lstatSync } = require('fs')
const path = fixture(t, 'prune-dev-bins')

Expand Down
6 changes: 3 additions & 3 deletions workspaces/arborist/test/arborist/reify.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const runScript = require('@npmcli/run-script')
const localeCompare = require('@isaacs/string-locale-compare')('en')
const tnock = require('../fixtures/tnock')
const fs = require('fs')
const fsp = require('node:fs/promises')
const fsp = require('fs/promises')
const npmFs = require('@npmcli/fs')

let failRm = false
Expand Down Expand Up @@ -71,10 +71,10 @@ const fspMock = {
},
}
// need this to be injected so that it doesn't pull from main cache
const { moveFile } = t.mock('@npmcli/fs', { 'node:fs/promises': fspMock })
const { moveFile } = t.mock('@npmcli/fs', { 'fs/promises': fspMock })
const mocks = {
fs: fsMock,
'node:fs/promises': fspMock,
'fs/promises': fspMock,
'@npmcli/fs': { ...npmFs, moveFile },
}

Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/test/isolated-mode.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const tap = require('tap')
const fs = require('fs')
const { readFile } = require('node:fs/promises')
const { readFile } = require('fs/promises')
const path = require('path')
const os = require('os')

Expand Down

0 comments on commit ae83cb3

Please sign in to comment.