General infinity literals for DateTimeOffset min/max values (#2390)

Fixes #2389 (cherry picked from commit e672715)
npgsql · Jun 1, 2022 · 0f05a3b · 0f05a3b
1 parent d5eed85
commit 0f05a3b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/EFCore.PG/Storage/Internal/Mapping/NpgsqlTimestampTzTypeMapping.cs b/src/EFCore.PG/Storage/Internal/Mapping/NpgsqlTimestampTzTypeMapping.cs
@@ -61,6 +61,19 @@ private string GenerateLiteralCore(object value)
                 };
 
             case DateTimeOffset dateTimeOffset:
+                if (!NpgsqlTypeMappingSource.DisableDateTimeInfinityConversions)
+                {
+                    if (dateTimeOffset == DateTimeOffset.MinValue)
+                    {
+                        return "-infinity";
+                    }
+
+                    if (dateTimeOffset == DateTimeOffset.MaxValue)
+                    {
+                        return "infinity";
+                    }
+                }
+
                 return dateTimeOffset.ToString("yyyy-MM-dd HH:mm:ss.FFFFFFzzz", CultureInfo.InvariantCulture);
 
             default:

diff --git a/test/EFCore.PG.Tests/Storage/NpgsqlTypeMappingTest.cs b/test/EFCore.PG.Tests/Storage/NpgsqlTypeMappingTest.cs
@@ -132,6 +132,14 @@ public void GenerateSqlLiteral_returns_timestamptz_infinity_literals()
         Assert.Equal(
             "TIMESTAMPTZ 'infinity'",
             GetMapping("timestamptz").GenerateSqlLiteral(DateTime.MaxValue));
+
+        Assert.Equal(
+            "TIMESTAMPTZ '-infinity'",
+            GetMapping("timestamptz").GenerateSqlLiteral(DateTimeOffset.MinValue));
+
+        Assert.Equal(
+            "TIMESTAMPTZ 'infinity'",
+            GetMapping("timestamptz").GenerateSqlLiteral(DateTimeOffset.MaxValue));
     }
 
     [Fact]