Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added/updated to npp.connections v1.1 #543

Closed
wants to merge 1 commit into from

Conversation

chcg
Copy link
Contributor

@chcg chcg commented Dec 11, 2022

@chcg chcg added the delayed correction to the plugin needed from plugin author label Dec 11, 2022
@rdipardo
Copy link
Contributor

@chcg, just a heads up, but you may want to eventually add a "npp-compatible-versions" field. v1.1 makes an unconditional call to SCI_GETTEXTRANGEFULL [1] — that won't work with anything older than N++ 8.4.3 (all builds)


[1]

$ git grep -niE -C 2 "Sci_(GETTEXTRANGE(FULL)?,)"
lib/nppplugin.pas-1046-  try
lib/nppplugin.pas-1047-    pt^.chrg := Range;
lib/nppplugin.pas:1048:    Size :=Sci_Send(SCI_GETTEXTRANGEFULL,0,LPARAM(pt));
lib/nppplugin.pas-1049-    if HasV5Apis then Inc(Size);
lib/nppplugin.pas-1050-    SetLength(S,Size);

$ git remote get-url origin
https://github.com/vladk1973/npp.connections.git

$ git describe --tags
v1.1-1-gf73784b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delayed correction to the plugin needed from plugin author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants