Github packages setup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradroid
commented
Oct 12, 2022
| @@ -30,7 +30,14 @@ buildscript { | |||
| } | |||
| } | |||
|
|
|||
| plugins { | |||
| id "maven-publish" | |||
| id "digital.wup.android-maven-publish" version "3.6.2" | |||
There was a problem hiding this comment.
If the AmityUIKit project used AGP 7.1 or newer we wouldn't need this dependency. Also, the scripts for attaching sources wouldn't be needed because we could simply use withSourcesJar() instead.
The project uses AGP 4.2.2 but I don’t think updating is a good idea.
If we update it might require us to migrate parts of the existing scripts which can be a lot of work.
Also, as Amity team updates their gradle scripts, they might not be compatible with the new AGP on our side so it can cause more work in the future when we’re pulling the new changes. Therefore I’ll leave it as is.
bradroid
requested review from
matsebc,
david-culpepper,
jeff-wright-noom,
James-Moody-noom and
marinpiskacnoom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a script for publishing all the java and android library modules to Github Packages.
I've already ran the script so the packages can be found here.
I've mostly followed this blog to create the script:
https://apiumhub.com/tech-blog-barcelona/publishing-multi-module-android-libraries/#Publishing_multi_module_Android_libraries