Utilise uvloop automatically for CLI if present #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolar
force-pushed
the
uvloop-if-present
branch
from
c15a6bf
to
76a39a1
Compare
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
nolar
force-pushed
the
uvloop-if-present
branch
from
76a39a1
to
a0634d7
Compare
nolar
changed the title
run()
nolar
force-pushed
the
uvloop-if-present
branch
from
a0634d7
to
f95c324
Compare
`uvloop` is a drop-in replacement for asyncio's event loops, which promises 2x–2.5x faster execution of the same i/o code (http://magic.io/blog/uvloop-blazing-fast-python-networking/). There is no reason to ignore it if it is installed. For convenience, Kopf can be installed as `pip install kopf[uvloop]` to bring the mode as a dependency. The implicit activation only affects the CLI mode — i.e. `kopf run …`. To disable, uninstall `uvloop`. For in-code invocations —such as `kopf.run()` or `KopfRunner`— it will use the preinstalled event loop policy (or the default one). `uvloop` is not activated implicitly if Kopf is embedded into a custom application. Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
nolar
force-pushed
the
uvloop-if-present
branch
from
f95c324
to
52f1f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uvloopis a drop-in replacement for asyncio's event loops, which promises 2x–2.5x faster execution of the same i/o code (http://magic.io/blog/uvloop-blazing-fast-python-networking/). There is no reason to ignore it if it is installed. For convenience, Kopf can be installed aspip install kopf[uvloop]to bring the mode as a dependency.This only affects the CLI mode (
kopf run …). For in-code execution —e.g. withkopf.run()orkopf.operator()— create or install the event loops explicitly.Supersedes #719.