Skip to content

Commit

Permalink
Work around MyPy 1.8.0 + Python 3.12 issues with wrong bool inference
Browse files Browse the repository at this point in the history
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
  • Loading branch information
nolar committed Jan 19, 2024
1 parent 85993ee commit de22a22
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions kopf/_core/engines/posting.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,14 @@ def createLock(self) -> None:
def filter(self, record: logging.LogRecord) -> bool:
# Only those which have a k8s object referred (see: `ObjectLogger`).
# Otherwise, we have nothing to post, and nothing to do.
# TODO: remove all bool() -- they were needed for Python 3.12 & MyPy 1.8.0 wrong inference.
settings: Optional[configuration.OperatorSettings]
settings = getattr(record, 'settings', None)
level_ok = settings is not None and record.levelno >= settings.posting.level
enabled = settings is not None and settings.posting.enabled
level_ok = settings is not None and bool(record.levelno >= settings.posting.level)
enabled = settings is not None and bool(settings.posting.enabled)
has_ref = hasattr(record, 'k8s_ref')
skipped = hasattr(record, 'k8s_skip') and getattr(record, 'k8s_skip')
return enabled and level_ok and has_ref and not skipped and super().filter(record)
skipped = hasattr(record, 'k8s_skip') and bool(getattr(record, 'k8s_skip'))
return enabled and level_ok and has_ref and not skipped and bool(super().filter(record))

def emit(self, record: logging.LogRecord) -> None:
# Same try-except as in e.g. `logging.StreamHandler`.
Expand Down

0 comments on commit de22a22

Please sign in to comment.