Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename prerelease builds for consistency #885

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

jasonkarns
Copy link
Member

@jasonkarns jasonkarns commented May 23, 2024

The filename structure is:

{distribution}-{version}

distributions can have a suffix (separated with +) that denote major
engine changes or platform components.
the version should generally be semver compliant
(- denotes pre release, + denotes build meta)

Hence parsing is "distro name up to first -", semver after;
Subdivide distro name by + for "augmentations". Words joined by
underscores.

Omitting the leading distro name implies "node" and must then begin with
a digit.

This has left the rc, nightly, and v8-canary builds not quite
following the pattern. With the upcoming improvements to version
listings, we need more stable naming.

This simply adds the missing node- prefix for nightly and rc builds.
v8-canary is more complicated. It is technically still a nightly build
(thus -nightly)
but with different v8 engine; so that's an augmentation within the
"distro name" and "v8 canary" is just word split thus +v8_canary.

Despite the names of the build defs, the installed versions are named like:

  • node-rc: v22.0.0-rc.2
  • node-nightly: v23.0.0-nightly202405231b965270a9
  • node+v8_canary: v23.0.0-v8-canary202405238df84f17b2

The filename structure is:

{distribution}-{version}

distributions can have a suffix (separated with +) that denote major
engine changes or platform components.
the version should generally be semver compliant
(- denotes pre release, + denotes build meta)

Hence parsing is "distro name up to first -", semver after;
Subdivide distro name by + for "augmentations". Words joined by
underscores.

Omitting the leading distro name implies "node" and must then begin with
a digit.

This has left the `rc`, `nightly`, and `v8-canary` builds not quite
following the pattern. With the upcoming improvements to version
listings, we need more stable naming.

This simply adds the missing node- prefix for nightly and rc builds.
v8-canary is more complicated. It is technically still a nightly build
(thus -nightly)
but with different v8 engine; so that's an augmentation within the
"distro name" and "v8 canary" is just word split thus +v8_canary.
@jasonkarns jasonkarns merged commit 41c5792 into main May 23, 2024
5 checks passed
@jasonkarns jasonkarns deleted the prerelease-names branch May 23, 2024 18:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant