rename prerelease builds for consistency #885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filename structure is:
{distribution}-{version}
distributions can have a suffix (separated with +) that denote major
engine changes or platform components.
the version should generally be semver compliant
(- denotes pre release, + denotes build meta)
Hence parsing is "distro name up to first -", semver after;
Subdivide distro name by + for "augmentations". Words joined by
underscores.
Omitting the leading distro name implies "node" and must then begin with
a digit.
This has left the
rc
,nightly
, andv8-canary
builds not quitefollowing the pattern. With the upcoming improvements to version
listings, we need more stable naming.
This simply adds the missing node- prefix for nightly and rc builds.
v8-canary is more complicated. It is technically still a nightly build
(thus -nightly)
but with different v8 engine; so that's an augmentation within the
"distro name" and "v8 canary" is just word split thus +v8_canary.
Despite the names of the build defs, the installed versions are named like:
v22.0.0-rc.2
v23.0.0-nightly202405231b965270a9
v23.0.0-v8-canary202405238df84f17b2