Added fix from #750, to access the IP of a sender of a UDP packet, to fix SDK 1.4.0 compability. #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev096 into master.
…ket, to fix SDK 1.4.0 compability.
|
Please avoid intermediate merge commits and squash your commits next time, thanks. See https://github.com/nodemcu/nodemcu-firmware/blob/dev/CONTRIBUTING.md#general-flow for details. |
|
@marcelstoer Do you want to merge this as-is? |
|
"Form follows function" is something I believe in. So yes, the dirty commit history shouldn't block this from being merged.However, as I can't assess the correctness of the actual changes one of you guys should merge it. |
jmattsson
added a commit
that referenced
this pull request
Nov 17, 2015
Added fix from #750, to access the IP of a sender of a UDP packet, to fix SDK 1.4.0 compability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.