fix: fixed callback invocations to check if session already closed (#705

)
nodemailer · Jul 29, 2024 · d06071b · d06071b
1 parent 4ef3eaa
commit d06071b
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/lib/pop3/connection.js b/lib/pop3/connection.js
@@ -727,6 +727,11 @@ class POP3Connection extends EventEmitter {
         }
 
         this._server.onFetchMessage(message, this.session, (err, stream) => {
+            if (!this.session) {
+                // already closed, do nothing
+                return;
+            }
+
             if (err) {
                 this._server.loggelf({
                     short_message: '[POP3RETR] error',
@@ -810,6 +815,11 @@ class POP3Connection extends EventEmitter {
         }
 
         this._server.onFetchMessage(message, this.session, (err, stream) => {
+            if (!this.session) {
+                // already closed, do nothing
+                return;
+            }
+
             if (err) {
                 this._server.loggelf({
                     short_message: '[POP3TOP] error',
@@ -1002,6 +1012,11 @@ class POP3Connection extends EventEmitter {
 
     openMailbox(next) {
         this._server.onListMessages(this.session, (err, listing) => {
+            if (!this.session) {
+                // already closed, do nothing
+                return;
+            }
+
             if (err) {
                 this.logger.info(
                     {