Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement BodyReadable.bytes #3391

Merged
merged 3 commits into from
Jul 6, 2024
Merged

feat: implement BodyReadable.bytes #3391

merged 3 commits into from
Jul 6, 2024
+98 −14

Conversation

tsctx
Copy link
Member

@tsctx tsctx commented Jul 3, 2024

Refs: #3262

@tsctx tsctx force-pushed the implement-readable-bytes branch from 952d8ef to 4712ae8 Compare July 3, 2024 11:21
mcollina
mcollina requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to the docs?

KhafraDev
KhafraDev approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a side note we should probably add a test similar to 9134ee6 to be safe

@tsctx
Copy link
Member Author

tsctx commented Jul 4, 2024

@mcollina ptal

mcollina
mcollina approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit db8e642 into nodejs:main Jul 6, 2024
30 checks passed
@tsctx tsctx deleted the implement-readable-bytes branch July 6, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ronag ronag ronag approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tsctx @mcollina @ronag @KhafraDev