interceptors: move throwOnError to interceptor

[mertcanaltin]

• Moved throwOnError handling to response-error interceptor.
• Updated retry tests to handle 400 status code properly.

Test Issue:

• Encountered 'BadRequestError' (status 400) in 'should not error if request is not meant to be retried' test.

Need assistance to resolve test failures.

[KhafraDev]

Please remove http-errors

[metcoder95]

Please do not forget to add docs and TS types 👍

[ronag]

Could we also apply it to one of the API decoreators?

e.g.

diff --git a/lib/api/api-request.js b/lib/api/api-request.js
index ced5590d..f91b830a 100644
--- a/lib/api/api-request.js
+++ b/lib/api/api-request.js
@@ -13,7 +13,7 @@ class RequestHandler extends AsyncResource {
       throw new InvalidArgumentError('invalid opts')
     }
 
-    const { signal, method, opaque, body, onInfo, responseHeaders, throwOnError, highWaterMark } = opts
+    const { signal, method, opaque, body, onInfo, responseHeaders, highWaterMark } = opts
 
     try {
       if (typeof callback !== 'function') {
@@ -54,7 +54,6 @@ class RequestHandler extends AsyncResource {
     this.trailers = {}
     this.context = null
     this.onInfo = onInfo || null
-    this.throwOnError = throwOnError
     this.highWaterMark = highWaterMark
     this.signal = signal
     this.reason = null
@@ -132,20 +131,14 @@ class RequestHandler extends AsyncResource {
     this.callback = null
     this.res = res
     if (callback !== null) {
-      if (this.throwOnError && statusCode >= 400) {
-        this.runInAsyncScope(getResolveErrorBodyCallback, null,
-          { callback, body: res, contentType, statusCode, statusMessage, headers }
-        )
-      } else {
-        this.runInAsyncScope(callback, null, null, {
-          statusCode,
-          headers,
-          trailers: this.trailers,
-          opaque,
-          body: res,
-          context
-        })
-      }
+      this.runInAsyncScope(callback, null, null, {
+        statusCode,
+        headers,
+        trailers: this.trailers,
+        opaque,
+        body: res,
+        context
+      })
     }
   }
 
@@ -200,7 +193,7 @@ function request (opts, callback) {
   }
 
   try {
-    this.dispatch(opts, new RequestHandler(opts, callback))
+    this.compose(responseErrorInterceptor()).dispatch(opts, new RequestHandler(opts, callback))
   } catch (err) {
     if (typeof callback !== 'function') {
       throw err

[ronag]

LGTM once CI is green

[metcoder95]

Tests seems to be failing

[mertcanaltin]

Tests seems to be failing

Solved 🚀

[metcoder95]

Let's add the respective TS types and docs 👍

[mertcanaltin]

Let's add the respective TS types and docs 👍

Which md file should I put the doc in, do you have any suggestions?

[metcoder95]

Which md file should I put the doc in, do you have any suggestions?

Within Dispatcher.md, there's a section there for interceptors that outlines the built-in ones 👍

[metcoder95]

Thanks! It LGTM, just smaller comments on the docs 👍