Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove autobahn reports from gitignore #3317

Closed
wants to merge 1 commit into from
Closed

remove autobahn reports from gitignore #3317

wants to merge 1 commit into from

Conversation

KhafraDev
Copy link
Member

part of #3312

@tsctx
Copy link
Member

tsctx commented Jun 8, 2024

json may not be necessary

tsctx
tsctx approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@tsctx tsctx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KhafraDev
Copy link
Member Author

it's not necessary for the report but could be useful for detecting test result changes

tsctx
tsctx approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@tsctx tsctx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina requested changes Jun 9, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1. These are over 1000 files with a total of 353468 lines. If we kept updating them, they would engulf our github repository. We need a different strategy for this.

I didn't expect the autobahn report to be this big. Is there a summary possible?

@KhafraDev
Copy link
Member Author

They won't need to be updated much - the tests are already passing. If we remove all of the html/json files other than index.html we lose out on any benefit of publishing it.

@mcollina
Copy link
Member

@ronag @Ethan-Arrowood have you got a solution for this?

@KhafraDev KhafraDev closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

@tsctx tsctx tsctx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KhafraDev @tsctx @mcollina