-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add cache testing #2623
test: add cache testing #2623
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
==========================================
+ Coverage 85.54% 87.28% +1.73%
==========================================
Files 76 81 +5
Lines 6858 7293 +435
==========================================
+ Hits 5867 6366 +499
+ Misses 991 927 -64 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure Every test here is already covered by WPTs. There is no reason to add these tests.
I think Matteo meant was that a test specifically for accessing the signal was needed, not that we need to duplicate the tests |
No description provided.