-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port autoselectfamily.js
tests to node:test
runner
#2570
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
73dd39f
Move utils to `/test/utils`
sosukesuzuki a291dcb
Use `p.completed`
sosukesuzuki 60e19c0
Make `ttype` return `boolean`
sosukesuzuki 087c60b
port `autoselectfamily.js` to `node:test` runner
sosukesuzuki 08f162d
Remove `node-test` helpers
sosukesuzuki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/** | ||
* A port of tap's `t.type` that can be used with `node:assert` | ||
* https://github.com/tapjs/tapjs/blob/511019b2ac0fa014370154c3a341a0e632f50b19/src/asserts/src/index.ts#L199 | ||
*/ | ||
function ttype (obj, klass) { | ||
const name = | ||
typeof klass === 'function' | ||
? klass.name || '(anonymous constructor)' | ||
: klass | ||
|
||
if (obj === klass) { | ||
return true | ||
} | ||
|
||
const tof = typeof obj | ||
const type = | ||
!obj && tof === 'object' | ||
? 'null' | ||
// treat as object, but not Object | ||
// t.type(() => {}, Function) | ||
: tof === 'function' && | ||
typeof klass === 'function' && | ||
klass !== Object | ||
? 'object' | ||
: tof | ||
|
||
if ( | ||
(type === 'number' && klass === Number) || | ||
(type === 'string' && klass === String) || | ||
(type === 'bigint' && klass === BigInt) || | ||
(klass === 'array' && Array.isArray(obj)) || | ||
(type === 'symbol' && klass === Symbol) | ||
) { | ||
return true | ||
} | ||
|
||
// simplest case, it literally is the same thing | ||
if (type === 'object' && klass !== 'object') { | ||
if (typeof klass === 'function') { | ||
return obj instanceof klass | ||
} | ||
|
||
// check prototype chain for name | ||
// at this point, we already know klass is not a function | ||
// if the klass specified is an obj in the proto chain, pass | ||
// if the name specified is the name of a ctor in the chain, pass | ||
for (let p = obj; p; p = Object.getPrototypeOf(p)) { | ||
const ctor = p.constructor && p.constructor.name | ||
if (p === klass || ctor === name) { | ||
return true | ||
} | ||
} | ||
} | ||
|
||
return type === name | ||
} | ||
|
||
module.exports = { | ||
ttype | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 08f162d