websocket: don't clone buffer (#3240)

* websocket: don't clone buffer * Apply suggestions from code review * fixup * Apply suggestions from code review
nodejs · May 10, 2024 · eadf781 · eadf781
1 parent f744596
commit eadf781
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 37 deletions.
diff --git a/lib/web/websocket/websocket.js b/lib/web/websocket/websocket.js
@@ -287,7 +287,7 @@ class WebSocket extends EventTarget {
       // not throw an exception must increase the bufferedAmount attribute
       // by the length of data’s buffer in bytes.
 
-      const ab = new FastBuffer(data, data.byteOffset, data.byteLength)
+      const ab = new FastBuffer(data.buffer, data.byteOffset, data.byteLength)
 
       const frame = new WebsocketFrameSend(ab)
       const buffer = frame.createFrame(opcodes.BINARY)

diff --git a/test/wpt/status/websockets.status.json b/test/wpt/status/websockets.status.json
@@ -16,42 +16,6 @@
       }
     }
   },
-  "Send-binary-arraybufferview-float32.any.js": {
-    "note": "TODO(@KhafraDev): investigate failure",
-    "fail": [
-      "Send binary data on a WebSocket - ArrayBufferView - Float32Array - Connection should be closed"
-    ]
-  },
-  "Send-binary-arraybufferview-float64.any.js": {
-    "note": "TODO(@KhafraDev): investigate failure",
-    "fail": [
-      "Send binary data on a WebSocket - ArrayBufferView - Float64Array - Connection should be closed"
-    ]
-  },
-  "Send-binary-arraybufferview-int16-offset.any.js": {
-    "note": "TODO(@KhafraDev): investigate failure",
-    "fail": [
-      "Send binary data on a WebSocket - ArrayBufferView - Int16Array with offset - Connection should be closed"
-    ]
-  },
-  "Send-binary-arraybufferview-int32.any.js": {
-    "note": "TODO(@KhafraDev): investigate failure",
-    "fail": [
-      "Send binary data on a WebSocket - ArrayBufferView - Int32Array - Connection should be closed"
-    ]
-  },
-  "Send-binary-arraybufferview-uint16-offset-length.any.js": {
-    "note": "TODO(@KhafraDev): investigate failure",
-    "fail": [
-      "Send binary data on a WebSocket - ArrayBufferView - Uint16Array with offset and length - Connection should be closed"
-    ]
-  },
-  "Send-binary-arraybufferview-uint32-offset.any.js": {
-    "note": "TODO(@KhafraDev): investigate failure",
-    "fail": [
-      "Send binary data on a WebSocket - ArrayBufferView - Uint32Array with offset - Connection should be closed"
-    ]
-  },
   "Create-on-worker-shutdown.any.js": {
     "skip": true,
     "//": "Node.js workers are different from web workers & don't work with blob: urls"