-
Notifications
You must be signed in to change notification settings - Fork 524
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request from GHSA-wqq4-5wpv-mx2g
* fix: delete 'cookie' and 'host' headers on cross-origin redirect * apply suggestion
- Loading branch information
Showing
2 changed files
with
52 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
'use strict' | ||
|
||
const { test } = require('tap') | ||
const { createServer } = require('http') | ||
const { once } = require('events') | ||
const { fetch } = require('../..') | ||
|
||
test('Cross-origin redirects clear forbidden headers', async (t) => { | ||
t.plan(5) | ||
|
||
const server1 = createServer((req, res) => { | ||
t.equal(req.headers.cookie, undefined) | ||
t.equal(req.headers.authorization, undefined) | ||
|
||
res.end('redirected') | ||
}).listen(0) | ||
|
||
const server2 = createServer((req, res) => { | ||
t.equal(req.headers.authorization, 'test') | ||
t.equal(req.headers.cookie, 'ddd=dddd') | ||
|
||
res.writeHead(302, { | ||
...req.headers, | ||
Location: `http://localhost:${server1.address().port}` | ||
}) | ||
res.end() | ||
}).listen(0) | ||
|
||
t.teardown(() => { | ||
server1.close() | ||
server2.close() | ||
}) | ||
|
||
await Promise.all([ | ||
once(server1, 'listening'), | ||
once(server2, 'listening') | ||
]) | ||
|
||
const res = await fetch(`http://localhost:${server2.address().port}`, { | ||
headers: { | ||
Authorization: 'test', | ||
Cookie: 'ddd=dddd' | ||
} | ||
}) | ||
|
||
const text = await res.text() | ||
t.equal(text, 'redirected') | ||
}) |
e041de3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good