fixup

nodejs · Jan 18, 2024 · 5598895 · 5598895
1 parent a2c244e
commit 5598895
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/cache/cache.js b/lib/cache/cache.js
@@ -8,7 +8,7 @@ const { webidl } = require('../fetch/webidl')
 const { Response, cloneResponse } = require('../fetch/response')
 const { Request, fromInnerRequest } = require('../fetch/request')
 const { Headers } = require('../fetch/headers')
-const { kState, kHeaders, kGuard, kRealm } = require('../fetch/symbols')
+const { kState, kHeaders, kGuard } = require('../fetch/symbols')
 const { fetching } = require('../fetch/index')
 const { urlIsHttpHttpsScheme, createDeferredPromise, readAllBytes } = require('../fetch/util')
 const assert = require('assert')
@@ -506,9 +506,9 @@ class Cache {
         const requestObject = fromInnerRequest(
           request,
           new AbortController().signal,
-          'immutable'
+          'immutable',
+          { settingsObject: request.client }
         )
-        requestObject[kRealm] = { settingsObject: request.client }
         // 5.4.2.1
         requestList.push(requestObject)
       }

diff --git a/lib/fetch/request.js b/lib/fetch/request.js
@@ -848,15 +848,19 @@ function cloneRequest (request) {
  * @param {any} innerRequest
  * @param {AbortSignal} signal
  * @param {'request' | 'immutable' | 'request-no-cors' | 'response' | 'none'} guard
+ * @param {any} [realm]
  * @returns {Request}
  */
-function fromInnerRequest (innerRequest, signal, guard) {
+function fromInnerRequest (innerRequest, signal, guard, realm) {
   const request = new Request(kConstruct)
   request[kState] = innerRequest
+  request[kRealm] = realm
   request[kSignal] = signal
+  request[kSignal][kRealm] = realm
   request[kHeaders] = new Headers(kConstruct)
   request[kHeaders][kHeadersList] = innerRequest.headersList
   request[kHeaders][kGuard] = guard
+  request[kHeaders][kRealm] = realm
   return request
 }