test: add headersList.toSortedArray slow-path test

nodejs · Feb 19, 2024 · 2450393 · 2450393
1 parent 92db1c8
commit 2450393
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/fetch/headers.js b/lib/fetch/headers.js
@@ -304,7 +304,7 @@ class HeadersList {
           array[left] = x
         }
       }
-      /* c8 ignore next 3 */
+      /* c8 ignore next 4 */
       if (!iterator.next().done) {
         // This is for debugging and will never be called.
         throw new TypeError('Unreachable')

diff --git a/test/fetch/headerslist-sortedarray.js b/test/fetch/headerslist-sortedarray.js
@@ -16,11 +16,22 @@ function generateAsciiString (length) {
 }
 
 test('toSortedArray (fast-path)', () => {
-  for (let i = 0; i < 2000; ++i) {
+  for (let i = 0; i < 1000; ++i) {
     const headersList = new HeadersList()
     for (let j = 0; j < 32; ++j) {
       headersList.append(generateAsciiString(8), generateAsciiString(3))
     }
     assert.deepStrictEqual(headersList.toSortedArray(), [...headersList].sort(compareHeaderName))
   }
 })
+
+// Do we really need it?
+test('toSortedArray (slow-path)', () => {
+  for (let i = 0; i < 1000; ++i) {
+    const headersList = new HeadersList()
+    for (let j = 0; j < 64; ++j) {
+      headersList.append(generateAsciiString(8), generateAsciiString(3))
+    }
+    assert.deepStrictEqual(headersList.toSortedArray(), [...headersList].sort(compareHeaderName))
+  }
+})