fetch: fix captureStackTrace (#3227)

* fetch: fix captureStackTrace * improve test case performance
nodejs · May 10, 2024 · 0a64b44 · 0a64b44
1 parent a613753
commit 0a64b44
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/index-fetch.js b/index-fetch.js
@@ -7,7 +7,7 @@ const fetchImpl = require('./lib/web/fetch').fetch
 module.exports.fetch = function fetch (resource, init = undefined) {
   return fetchImpl(resource, init).catch((err) => {
     if (err && typeof err === 'object') {
-      Error.captureStackTrace(err, this)
+      Error.captureStackTrace(err)
     }
     throw err
   })

diff --git a/index.js b/index.js
@@ -108,7 +108,7 @@ module.exports.fetch = async function fetch (init, options = undefined) {
     return await fetchImpl(init, options)
   } catch (err) {
     if (err && typeof err === 'object') {
-      Error.captureStackTrace(err, this)
+      Error.captureStackTrace(err)
     }
 
     throw err

diff --git a/test/fetch/client-error-stack-trace.js b/test/fetch/client-error-stack-trace.js
@@ -2,9 +2,14 @@
 
 const { test } = require('node:test')
 const assert = require('node:assert')
-const { fetch } = require('../..')
+const { fetch, setGlobalDispatcher, Agent } = require('../..')
 const { fetch: fetchIndex } = require('../../index-fetch')
 
+setGlobalDispatcher(new Agent({
+  headersTimeout: 500,
+  connectTimeout: 500
+}))
+
 test('FETCH: request errors and prints trimmed stack trace', async (t) => {
   try {
     await fetch('http://a.com')