Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to node 8.9.4. #6

Merged
merged 4 commits into from
Mar 6, 2018
Merged

Update to node 8.9.4. #6

merged 4 commits into from
Mar 6, 2018

Conversation

mcollina
Copy link
Member

As titled.

@mcollina mcollina mentioned this pull request Feb 28, 2018
Closed
@mafintosh
Copy link
Member

LGTM

@mcollina mcollina force-pushed the update-8-9-4 branch 4 times, most recently from e0d4e29 to d8f627a Compare March 1, 2018 22:19
@mcollina
Copy link
Member Author

mcollina commented Mar 5, 2018

CI: https://ci.nodejs.org/view/MyJobs/job/string_decoder-pipeline/2/

@mcollina
Copy link
Member Author

mcollina commented Mar 6, 2018

CI: https://ci.nodejs.org/view/MyJobs/job/string_decoder-pipeline/5/console
(this should be green)

@mcollina
Copy link
Member Author

mcollina commented Mar 6, 2018

CI passed.

@mcollina mcollina merged commit f12f26e into master Mar 6, 2018
@mcollina mcollina deleted the update-8-9-4 branch March 6, 2018 09:53
@mcollina mcollina mentioned this pull request Mar 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafintosh mafintosh mafintosh approved these changes

@calvinmetcalf calvinmetcalf Awaiting requested review from calvinmetcalf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @mafintosh