This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
[WIP] quic: fixup up client-connect-multiple-sequential #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
commented
Feb 4, 2020
| req.close(); | ||
| })); | ||
| })); | ||
| reqs.push(once(req, 'close')); |
There was a problem hiding this comment.
If we change this line to await once(req, 'close'); the test will hang. (and remove the await Promise.all(reqs); line below
|
The test was added by me in #176 … I intentionally provided it in two separate variants, one in which the requests are started in parallel and one where they are started sequentially. This PR here would essentially un-do the point of having the sequential variant, so yes, this seems like it would hide a bug to me. |
|
Yep, that's pretty much what I figured. There's something in the shutdown flow that's broken. I think it's also the source of the segfaults I've been seeing in various other tests. Will be chasing that down :-) |
jasnell
changed the title
|
Closed in favor of #339 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@addaleax or @danbev ... I can't remember exactly who added this test but it needed a bit of a fixup in order to successfully run but it's not clear if the fixup is testing the right thing or if there's another bug in here. Well, actually, I definitely think there's another bug in here :-) ... so definitely needs a lookover