add momentum scrolling #414
Conversation
| @@ -9,6 +9,8 @@ body | |||
| flex-direction column | |||
| min-height 100vh | |||
| margin 0 | |||
| overflow-y scroll; /* has to be scroll, not auto */ | |||
| -webkit-overflow-scrolling touch | |||
There was a problem hiding this comment.
are we using autoprefixer for this?
There was a problem hiding this comment.
Looks like the stylus-auto prefixer plugin was installed? Is there anything special I need to do to configure it?
On Dec 9, 2015, at 2:41 PM, Steve Mao notifications@github.com wrote:
In layouts/css/layout/_sticky-footer.styl:
@@ -9,6 +9,8 @@ body
flex-direction column
min-height 100vh
margin 0
- overflow-y scroll; /* has to be scroll, not auto */
- -webkit-overflow-scrolling touch
are we using autoprefixer for this?—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
I think its already configured.
overflow-scrolling touch should just work but its not really standard.
There was a problem hiding this comment.
What's the standard way to turning on the momentum scrolling? I really do enjoy browsing through the docs on my phone and it's such a pain on my thumb when I have to use it so much to find my spot again (this is the only way I know how :/).
On Dec 9, 2015, at 7:29 PM, Steve Mao notifications@github.com wrote:
In layouts/css/layout/_sticky-footer.styl:
@@ -9,6 +9,8 @@ body
flex-direction column
min-height 100vh
margin 0
- overflow-y scroll; /* has to be scroll, not auto */
- -webkit-overflow-scrolling touch
I think its already configured.overflow-scrolling touch should just work but its not really standard.
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
I'm not saying your doing wrong. I'm saying its not standard feature. https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-overflow-scrolling
And I'm just saying autoprefixer should handle the prefixing.
There was a problem hiding this comment.
Ah, I see. Sorry about that!
On Dec 9, 2015, at 7:56 PM, Steve Mao notifications@github.com wrote:
In layouts/css/layout/_sticky-footer.styl:
@@ -9,6 +9,8 @@ body
flex-direction column
min-height 100vh
margin 0
- overflow-y scroll; /* has to be scroll, not auto */
- -webkit-overflow-scrolling touch
I'm not saying your doing wrong. I'm saying its not standard feature. https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-overflow-scrolling—
Reply to this email directly or view it on GitHub.
|
nodejs/node#5878 adds momentum scrolling to the docs. If we're going with it, we should probably do it for the main site too. cc: @lpinca |
| @@ -9,6 +9,8 @@ body | |||
| flex-direction column | |||
| min-height 100vh | |||
| margin 0 | |||
| overflow-y scroll; /* has to be scroll, not auto */ | |||
|
Looks fine, but I'm gonna try it first. |
|
Hmm I'm not sure why but I can't see the difference here with it enabled. |
|
@moorebrett0 Hi, can you please have a look at the comments above and update your PR? I'd like to get it merged. |
|
I tried pulling again this change and can't see the difference on my iPhone. Scroll works the same with or without this change. |
|
Hey there, sorry for the delayed response - removed the semi colon. This seems to work for me on ios-9 can anyone confirm? |
|
@nodejs/website collaborators with iOS devices, can you please test this pull request? |
|
There is no difference on my iPhone too. Used device: iPhone 6+ |
|
I close this as there is no advantage in getting this merged. If someone can prove otherwise, please reopen. |
Add momentum scrolling for IOS makes reading the docs easier on mobile.