Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin translations #3056

Merged
merged 197 commits into from
Apr 2, 2020
Merged

New Crowdin translations #3056

merged 197 commits into from
Apr 2, 2020

Conversation

nodejs-crowdin-zz
Copy link
Contributor

@nodejs-crowdin-zz nodejs-crowdin-zz commented Apr 1, 2020

Excluded /blog from translation
Updated project configuration to export only fully translated files. Related discussion with @XhmikosR : #3050

I believe that's not a good way, because we will never translate the website #3050 (comment), so it's kind of temporary solution, until I'll update build scripts.

This PR still contain some files that's not translated, but it's going from copy/pasted files between locales. Crowdin thoughts that this files is actual translation for original file, and that's why it's here. I think we can live with it for now.

@nodejs/website
@nodejs/i18n
@nodejs/i18n-api

Copy link
Contributor

@alexandrtovmach alexandrtovmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting issue that happens only for already translated docs. Fixed once and shouldn't happen again

locale/es/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/es/download/releases.md Outdated Show resolved Hide resolved
locale/fr/about/resources.md Outdated Show resolved Hide resolved
locale/fr/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/fr/download/releases.md Outdated Show resolved Hide resolved
locale/ro/about/resources.md Outdated Show resolved Hide resolved
locale/ro/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/ro/download/releases.md Outdated Show resolved Hide resolved
@XhmikosR
Copy link
Contributor

XhmikosR commented Apr 1, 2020

I still see English-only files in this branch...

@alexandrtovmach
Copy link
Contributor

Please read description:

This PR still contain some files that's not translated, but it's going from copy/pasted files between locales. Crowdin thoughts that this files is actual translation for original file, and that's why it's here. I think we can live with it for now.

@SEWeiTung
Copy link
Contributor

Considering there are some files untranslated, I'll put it into "On hold" state until all of these files are translated, but if you think it's unnecessary, you can remove the label as well.

@alexandrtovmach
Copy link
Contributor

@MaledongGit It's unnecessary because this PR is initial bunch of translations. I wouldn't like to wait until it become translated, because it can take long.

@alexandrtovmach
Copy link
Contributor

I'm going to merge it, because it's blocking me to continue configuring localization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants