Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json: require Node.js 10. #2626

Merged
merged 2 commits into from
Sep 30, 2019
Merged

package.json: require Node.js 10. #2626

merged 2 commits into from
Sep 30, 2019

Conversation

XhmikosR
Copy link
Contributor

So that we use mkdir's recursive option later.

Or should I make this >=10.12.0 since that's when it was added? https://nodejs.org/api/fs.html#fs_fs_mkdir_path_options_callback

/CC @phillipj

@phillipj
Copy link
Member

Your suggestion of being even more specific with >=10.12.0 sounds reasonable to me. This is mainly for documenting our requirements, as it doesn't have anything to do with what's used in either CI or the hosting server (as mentioned in #2544 (comment)).

phillipj
phillipj approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@phillipj phillipj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillipj phillipj merged commit 6387215 into nodejs:master Sep 30, 2019
@XhmikosR XhmikosR deleted the master-xmr-node-10-min branch September 30, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipj phillipj phillipj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @phillipj