Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smooth sentence to fit Korean grammar #2003

Merged
merged 1 commit into from
Jan 30, 2019
Merged

smooth sentence to fit Korean grammar #2003

merged 1 commit into from
Jan 30, 2019

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Jan 23, 2019

previous sentence was grammatically incorrect in Korean.

@fhemberger
Copy link
Contributor

/cc @nodejs/nodejs-ko Please review

Copy link
Contributor

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Epitaph" means 비문(碑文), not 비문(非文). How about saying "grammatically incorrect" or something in the commit message?

@hallazzang
Copy link
Contributor Author

@yous What a shame, thank you for the correction. I'll change it ASAP.

previous sentence was grammatically incorrect in Korean.
@hallazzang
Copy link
Contributor Author

Done. Please check it again.

@yous
Copy link
Contributor

yous commented Jan 30, 2019

LGTM. 👍

@fhemberger fhemberger merged commit 5226332 into nodejs:master Jan 30, 2019
@fhemberger
Copy link
Contributor

Thank you!

@hallazzang hallazzang deleted the patch-2 branch January 31, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants