Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributor-list/package-lock.json. #1639

Merged
merged 1 commit into from
May 1, 2018
Merged

Update contributor-list/package-lock.json. #1639

merged 1 commit into from
May 1, 2018

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 29, 2018

This updates hoek@2 to hoek@4.2.1.

I wasn't able to test the relevant script because it didn't work for me even with no changes. So, maybe someone else can confirm that it's still in use and that it works? (Maybe GitHub was having issues when I tried? I'm pretty sure my API token would have the needed permissions.)

This updates hoek@2 to hoek@4.2.1.
@WaleedAshraf
Copy link
Contributor

Copy link
Contributor

@WaleedAshraf WaleedAshraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran the script without any error with these steps.

  • Pulled latest
  • npm install
  • GITHUB_API_TOKEN=<your token> node index.js <since date: YYYY-MM-DD>

@Trott
Copy link
Member Author

Trott commented Apr 29, 2018

@WaleedAshraf It's in package-lock.json, not package.json, because it's a dependency of a dependency.

@Trott
Copy link
Member Author

Trott commented Apr 29, 2018

I just ran the script without any error with these steps.

👍 Thanks!

@Trott
Copy link
Member Author

Trott commented Apr 29, 2018

(For what it's worth, those are the steps I took and it seemed to take a looooong time. Maybe I just wasn't patient enough? I think I waited a minute or two.)

@WaleedAshraf
Copy link
Contributor

WaleedAshraf commented Apr 29, 2018

Maybe something with the date. What date you used?
For me with 2018-01-01, it took few seconds.

@fhemberger
Copy link
Contributor

@Trott Yes, it's still in use and it should work. ;)

@Trott
Copy link
Member Author

Trott commented Apr 30, 2018

I'm going to guess it's my API token/account permissions. Regardless, as long as it is working, great.

@fhemberger
Copy link
Contributor

@Trott Why are there two PRs for this change? 🤔

@WaleedAshraf
Copy link
Contributor

@fhemberger One is for nodejs.org/package-lock.json and other for nodejs.org/scripts/contributor-list/package-lock.json

I think both can be closed?

@Trott
Copy link
Member Author

Trott commented Apr 30, 2018

I think both can be closed?

No, they should not be closed. hoek should be updated.

Copy link
Contributor

@WaleedAshraf WaleedAshraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca merged commit 22c4f69 into nodejs:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants