Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove de-chartered Intl working group #1513

Merged
merged 2 commits into from
Dec 12, 2017
Merged

remove de-chartered Intl working group #1513

merged 2 commits into from
Dec 12, 2017

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 11, 2017

@Trott Trott mentioned this pull request Dec 11, 2017
Closed
mhdawson
mhdawson approved these changes Dec 11, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpinca
lpinca approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it should be removed also for other locales.

@Trott
Copy link
Member Author

Trott commented Dec 12, 2017

LGTM but it should be removed also for other locales.

Oh, the irony.

Removed it from the only two locales that had it. Kept it as a separate commit in case it ought to be moved to a new PR or something. PTAL.

@Trott
Copy link
Member Author

Trott commented Dec 12, 2017

@nodejs/nodejs-ko

@yous
Copy link
Contributor

yous commented Dec 12, 2017

LGTM for ko locale.

@fhemberger fhemberger merged commit 576b2fe into nodejs:master Dec 12, 2017
@fhemberger
Copy link
Contributor

Thanks! 👍

@srl295
Copy link
Member

srl295 commented Dec 12, 2017

@Trott Internationalization: fresh irony served daily.

@Riveoxx Riveoxx mentioned this pull request Aug 1, 2022
Open
@ryan-ally ryan-ally mentioned this pull request Aug 1, 2022
Merged
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

@lpinca lpinca lpinca approved these changes

@daxlab daxlab daxlab approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @yous @fhemberger @srl295 @lpinca @daxlab @mhdawson