Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/l: 32bit linux is experimental #1446

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Conversation

refack
Copy link
Contributor

@refack refack commented Nov 3, 2017

@seishun
Copy link

seishun commented Nov 3, 2017

What about when 32-bit builds stop being built?

@refack
Copy link
Contributor Author

refack commented Nov 3, 2017

What about when 32-bit builds stop being built?

IMHO new box should be removed.

@seishun
Copy link

seishun commented Nov 3, 2017

Which new box?

@refack
Copy link
Contributor Author

refack commented Nov 3, 2017

Which new box?

The new link in secondary-download-matrix.hbs
image

@refack
Copy link
Contributor Author

refack commented Nov 3, 2017

Cross-ref: nodejs/node#16723

@seishun
Copy link

seishun commented Nov 3, 2017

Ah, agree.

gibfahn
gibfahn previously requested changes Nov 3, 2017
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking so this doesn't get landed accidentally before nodejs/node#16723 is resolved.

@gibfahn
Copy link
Member

gibfahn commented Nov 3, 2017

I think we should call out that it's experimental, I'm not even sure that it should continue to be on the main downloads page. I think we want to make sure people who are automatically downloading 32-bit builds notice the change (and come tell us that they still use 32-bit).

@refack
Copy link
Contributor Author

refack commented Nov 10, 2017

I completely removed the listing of the 32 bit linux binary. If people will come looking for it hope they will raise an issue that it is missing.

@seishun
Copy link

seishun commented Nov 10, 2017

@gibfahn unless it's required that Tier 1 and Tier 2 platforms must have public builds, I think this can be unblocked now.

@gibfahn
Copy link
Member

gibfahn commented Nov 10, 2017

@gibfahn unless it's required that Tier 1 and Tier 2 platforms must have public builds, I think this can be unblocked now.

I think it's reasonable to say Tier 1 platforms should have public builds where possible.

@fhemberger
Copy link
Contributor

Just merge it whenever you're ready.

refack added a commit to refack/node that referenced this pull request Nov 13, 2017
PR-URL: nodejs#16723
Refs: nodejs/build#885
Refs: nodejs/nodejs.org#1446
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@refack refack dismissed gibfahn’s stale review November 13, 2017 19:58

Blocking issue landed

@refack refack merged commit e818337 into nodejs:master Nov 13, 2017
evanlucas pushed a commit to nodejs/node that referenced this pull request Nov 14, 2017
PR-URL: #16723
Refs: nodejs/build#885
Refs: nodejs/nodejs.org#1446
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@refack refack deleted the no-32-linux-for-9 branch November 15, 2017 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants