Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix assert.equal to strictEq #9999

Closed
wants to merge 1 commit into from
Closed

test: fix assert.equal to strictEq #9999

wants to merge 1 commit into from

Conversation

mfhan
Copy link
Contributor

@mfhan mfhan commented Dec 1, 2016

  • make -j4 test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
    Affected core subsystem: test
    On line 10: changed assert.equal to "assert.strictEqual(bytes, buf1.length + buf2.length);"

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Dec 3, 2016
cjihrig
cjihrig approved these changes Dec 5, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM.

@Trott
Copy link
Member

Trott commented Dec 8, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5320/

@lpinca
Copy link
Member

lpinca commented Dec 16, 2016

New CI: https://ci.nodejs.org/job/node-test-pull-request/5438/

@lpinca
Copy link
Member

lpinca commented Dec 16, 2016

Landed in 5a41a72.

Thanks!

@lpinca lpinca closed this Dec 16, 2016
lpinca pushed a commit that referenced this pull request Dec 16, 2016
@mfhan @lpinca
test: refactor test-dgram-send-callback-multi-buffer
5a41a72 
* use assert.strictEqual() instead of assert.equal()

PR-URL: #9999
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit that referenced this pull request Dec 17, 2016
@mfhan @italoacasas
test: refactor test-dgram-send-callback-multi-buffer
fb297cb 
* use assert.strictEqual() instead of assert.equal()

PR-URL: #9999
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Dec 17, 2016
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
@mfhan @cjihrig
test: refactor test-dgram-send-callback-multi-buffer
d6a5496 
* use assert.strictEqual() instead of assert.equal()

PR-URL: #9999
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
@mfhan @MylesBorins
test: refactor test-dgram-send-callback-multi-buffer
cac63f0 
* use assert.strictEqual() instead of assert.equal()

PR-URL: #9999
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@mfhan @MylesBorins
test: refactor test-dgram-send-callback-multi-buffer
41e5d94 
* use assert.strictEqual() instead of assert.equal()

PR-URL: #9999
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@mfhan @MylesBorins
test: refactor test-dgram-send-callback-multi-buffer
92e3f8f 
* use assert.strictEqual() instead of assert.equal()

PR-URL: #9999
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mfhan @Trott @lpinca @jasnell @cjihrig @mscdex @MylesBorins @imyller @nodejs-github-bot