Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use assert.strictEqual in test-cli-eval #9919

Closed
wants to merge 1 commit into from
+18 −17
Closed

test: use assert.strictEqual in test-cli-eval #9919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions test/parallel/test-cli-eval.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ var filename = __filename.replace(/\\/g, '/');
// assert that nothing is written to stdout
child.exec(nodejs + ' --eval 42',
function(err, stdout, stderr) {
assert.equal(stdout, '');
assert.equal(stderr, '');
assert.strictEqual(stdout, '');
assert.strictEqual(stderr, '');
});

// assert that "42\n" is written to stderr
child.exec(nodejs + ' --eval "console.error(42)"',
function(err, stdout, stderr) {
assert.equal(stdout, '');
assert.equal(stderr, '42\n');
assert.strictEqual(stdout, '');
assert.strictEqual(stderr, '42\n');
});

// assert that the expected output is written to stdout
Expand All @@ -36,21 +36,21 @@ child.exec(nodejs + ' --eval "console.error(42)"',

child.exec(cmd + '42',
function(err, stdout, stderr) {
assert.equal(stdout, '42\n');
assert.equal(stderr, '');
assert.strictEqual(stdout, '42\n');
assert.strictEqual(stderr, '');
});

child.exec(cmd + "'[]'", common.mustCall(
function(err, stdout, stderr) {
assert.equal(stdout, '[]\n');
assert.equal(stderr, '');
assert.strictEqual(stdout, '[]\n');
assert.strictEqual(stderr, '');
}));
});

// assert that module loading works
child.exec(nodejs + ' --eval "require(\'' + filename + '\')"',
function(status, stdout, stderr) {
assert.equal(status.code, 42);
assert.strictEqual(status.code, 42);
});

// Check that builtin modules are pre-defined.
Expand All @@ -63,7 +63,7 @@ child.exec(nodejs + ' --print "os.platform()"',
// module path resolve bug, regression test
child.exec(nodejs + ' --eval "require(\'./test/parallel/test-cli-eval.js\')"',
function(status, stdout, stderr) {
assert.equal(status.code, 42);
assert.strictEqual(status.code, 42);
});

// Missing argument should not crash
Expand All @@ -74,28 +74,29 @@ child.exec(nodejs + ' -e', common.mustCall(function(status, stdout, stderr) {

// empty program should do nothing
child.exec(nodejs + ' -e ""', function(status, stdout, stderr) {
assert.equal(stdout, '');
assert.equal(stderr, '');
assert.strictEqual(stdout, '');
assert.strictEqual(stderr, '');
});

// "\\-42" should be interpreted as an escaped expression, not a switch
child.exec(nodejs + ' -p "\\-42"',
function(err, stdout, stderr) {
assert.equal(stdout, '-42\n');
assert.equal(stderr, '');
assert.strictEqual(stdout, '-42\n');
assert.strictEqual(stderr, '');
});

child.exec(nodejs + ' --use-strict -p process.execArgv',
function(status, stdout, stderr) {
assert.equal(stdout, "[ '--use-strict', '-p', 'process.execArgv' ]\n");
assert.strictEqual(stdout,
"[ '--use-strict', '-p', 'process.execArgv' ]\n");
});

// Regression test for https://github.com/nodejs/node/issues/3574
const emptyFile = path.join(common.fixturesDir, 'empty.js');
child.exec(nodejs + ` -e 'require("child_process").fork("${emptyFile}")'`,
function(status, stdout, stderr) {
assert.equal(stdout, '');
assert.equal(stderr, '');
assert.strictEqual(stdout, '');
assert.strictEqual(stderr, '');
});

// Regression test for https://github.com/nodejs/node/issues/8534.
Expand Down