Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.7.0 proposal #9736

Merged
merged 109 commits into from
Dec 6, 2016
Merged

v4.7.0 proposal #9736

merged 109 commits into from
Dec 6, 2016

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Nov 22, 2016

2016-12-06, Version 4.7.0 'Argon' (LTS), @thealphanerd

This LTS release comes with 108 commits. This includes 30 which are doc related, 28 which are test related, 16 which are build / tool related, and 4 commits which are updates to dependencies.

Notable Changes

The SEMVER-MINOR changes include:

  • build: export openssl symbols on Windows making it possible to build addons linking against the bundled version of openssl (Alex Hultman) #7576
  • debugger: make listen address configurable in the debugger server (Ben Noordhuis) #3316
  • dgram: generalized send queue to handle close fixing a potential throw when dgram socket is closed in the listening event handler. (Matteo Collina) #7066
  • http: Introduce the 451 status code "Unavailable For Legal Reasons" (Max Barinov) #4377
  • tls: introduce secureContext for tls.connect which is useful for caching client certificates, key, and CA certificates. (Fedor Indutny) #4246

Notable SEMVER-PATCH changes include:

  • build:
    • introduce the configure --shared option for embedders (sxa555) #6994
  • gtest: the test reporter now outputs tap comments as yamlish (Johan Bergström) #9262
  • src: node no longer aborts when c-ares initialization fails (Ben Noordhuis) #8710
  • tls: fix memory leak when writing data to TLSWrap instance during handshake (Fedor Indutny) #9586

Commits

  • [ed31f9cc30] - benchmark: add microbenchmarks for ES Map (Rod Vagg) #7581
  • [c5181eda4b] - build: reduce noise from doc target (Daniel Bevenius) #9457
  • [59d821debe] - build: use wxneeded on openbsd (Aaron Bieber) #9232
  • [7c73105606] - build: run cctests as part of test-ci target (Ben Noordhuis) #8034
  • [3919edb47e] - build: don't build icu with -fno-rtti (Ben Noordhuis) #8886
  • [e97723b18c] - build: abstract out shared library suffix (Stewart Addison) #9385
  • [0138b4db7c] - build: windows sharedlib support (Stewart Addison) #9385
  • [f21c2b9d3b] - build: configure --shared (sxa555) #6994
  • [bb2fdf58f7] - build: cherry pick V8 change for windows DLL support (Stefan Budeanu) #8084
  • [84849f186f] - (SEMVER-MINOR) build: export more openssl symbols on Windows (Alex Hultman) #7576
  • [3cefd65e90] - build: export openssl symbols on windows (Ben Noordhuis) #6274
  • [4de7a6e291] - build: fix config.gypi target (Daniel Bevenius) #9053
  • [9389572cbc] - crypto: fix faulty logic in iv size check (Ben Noordhuis) #9032
  • [748e424163] - (SEMVER-MINOR) debugger: make listen address configurable (Ben Noordhuis) #3316
  • [c1effb1255] - deps: fix build with libc++ 3.8.0 (Johan Bergström) #9763
  • [eb34f687d5] - deps: revert default gtest reporter change (Brian White) #8948
  • [4c47446133] - deps: make gtest output tap (Ben Noordhuis) #8034
  • [91fce10aee] - deps: back port OpenBSD fix in c-ares/c-ares (Aaron Bieber) #9232
  • [4571c84c67] - (SEMVER-MINOR) dgram: generalized send queue to handle close (Matteo Collina) #7066
  • [d3c25c19ef] - doc: update minute-taking procedure for CTC (Rich Trott) #9425
  • [861b689c01] - doc: update GOVERNANCE.md to use "meeting chair" (Rich Trott) #9432
  • [5e820ae746] - doc: update Diagnostics WG info (Josh Gavant) #9329
  • [e08173a2f1] - doc: fix outdate ninja link (Yangyang Liu) #9278
  • [462c640a51] - doc: fix typo in email address in README (Rich Trott) #8941
  • [fc77cbb5b1] - doc: make node(1) more consistent with tradition (Alex Jordan) #8902
  • [66e26cd253] - doc: child_process.execSync .stdio default is pipe (Kenneth Skovhus) #9701
  • [524ebfb5dd] - doc: child_process .stdio accepts a String type (Kenneth Skovhus) #9701
  • [475fe96852] - doc: simplify process.memoryUsage() example code (Thomas Watson Steen) #9560
  • [c48c318806] - doc: change ./node to node in debugger.md (AnnaMag) #8943
  • [00a178257c] - doc: update CONTRIBUTING.md to address editing PRs (Gibson Fahnestock) #9259
  • [2b2dde855a] - doc: add italoacasas to collaborators (Italo A. Casas) #9677
  • [0f41058e41] - doc: clarify relation between a file and a module (marzelin) #9026
  • [d1d207bd75] - doc: add Sakthipriyan to the CTC (Rod Vagg) #9427
  • [9dad98bdf1] - doc: add 2016-10-26 CTC meeting minutes (Rich Trott) #9348
  • [824009296a] - doc: add 2016-10-05 CTC meeting minutes (Josh Gavant) #9326
  • [1a701f1723] - doc: add 2016-09-28 CTC meeting minutes (Josh Gavant) #9325
  • [e9c6aff113] - doc: add 2016-10-19 CTC meeting minutes (Josh Gavant) #9193
  • [c1e5e663a9] - doc: improve header styling for API docs (Jeremiah Senkpiel) #8811
  • [279e30c3ee] - doc: add CTC meeting minutes for 2016-10-12 (Michael Dawson) #9070
  • [3b839d1855] - doc: remove confusing reference in governance doc (Rich Trott) #9073
  • [e564cb6af4] - doc: add ctc-review label information (Rich Trott) #9072
  • [68ccc7a512] - doc: update reference to list hash algorithms in crypto.md (scott stern) #9043
  • [132425a058] - doc: specify that errno is a number, not a string (John Vilk) #9007
  • [695ee1e77b] - doc: highlight deprecated API in ToC (Ilya Frolov) #7189
  • [4f8bf1bcf8] - doc: explains why Reviewed-By is added in PRs (jessicaquynh) #9044
  • [af645a0553] - doc: explain why GitHub merge button is not used (jessicaquynh) #9044
  • [f472c09e90] - doc: reference signal(7) for the list of signals (Emanuele DelBono) #9323
  • [88079817c2] - doc: fix typo in http.md (anu0012) #9144
  • [9f0ef5a4f2] - doc: fix heading type for v4.6.2 changelog (Myles Borins) #9515
  • [f6f0b387ea] - events: pass the original listener added by once (DavidCai) #6394
  • [02e6c84de2] - gitignore: ignore all tap files (Johan Bergström) #9262
  • [a7ae8876f9] - governance: expand use of CTC issue tracker (Rich Trott) #8945
  • [36abbbe736] - gtest: output tap comments as yamlish (Johan Bergström) #9262
  • [50a4471aff] - http: fix connection upgrade checks (Brian White) #8238
  • [c94482b167] - (SEMVER-MINOR) http: 451 status code "Unavailable For Legal Reasons" (Max Barinov) #4377
  • [12da2581a8] - https: fix memory leak with https.request() (Ilkka Myller) #8647
  • [3b448a7f12] - lib: changed var to const in linkedlist (Adri Van Houdt) #8609
  • [a3a184d40a] - lib: fix TypeError in v8-polyfill (Wyatt Preul) #8863
  • [423846053b] - lib: remove let from for loops (Myles Borins) #8873
  • [9a192a9683] - net: fix ambiguity in EOF handling (Fedor Indutny) #9066
  • [62e83b363e] - src: Malloc/Calloc size 0 returns non-null pointer (Rich Trott) #8572
  • [51e09d00c4] - src: normalize malloc, realloc (Michael Dawson) #7564
  • [3b5cedebd1] - src: renaming ares_task struct to node_ares_task (Daniel Bevenius) #7345
  • [e5d2a95d68] - src: remove out-of-date TODO comment (Daniel Bevenius) #9000
  • [b4353e9017] - src: fix typo in #endif comment (Juan Andres Andrango) #8989
  • [f0192ec195] - src: don't abort when c-ares initialization fails (Ben Noordhuis) #8710
  • [f669a08b76] - src: fix typo rval to value (Miguel Angel Asencio Hurtado) #9023
  • [9b9762ccec] - streams: fix regression in unpipe() (Anna Henningsen) #9171
  • [cc36a63205] - test: remove watchdog in test-debug-signal-cluster (Rich Trott) #9476
  • [9144d373ba] - test: cleanup test-dgram-error-message-address (Michael Macherey) #8938
  • [96bdfae041] - test: improve test-debugger-util-regression (Santiago Gimeno) #9490
  • [2c758861c0] - test: move timer-dependent test to sequential (Rich Trott) #9431
  • [d9955fbb17] - test: add test for HTTP client "aborted" event (Kyle E. Mitchell) #7376
  • [b0476c5590] - test: fix flaky test-fs-watch-recursive on OS X (Rich Trott) #9303
  • [bcd156f4ab] - test: refactor test-async-wrap-check-providers (Gerges Beshay) #9297
  • [9d5e7f5c85] - test: use strict assertions in module loader test (Ben Noordhuis) #9263
  • [6d742b3fdd] - test: remove err timer from test-http-set-timeout (BethGriggs) #9264
  • [51b251d8eb] - test: add coverage for spawnSync() killSignal (cjihrig) #8960
  • [fafffd4f99] - test: fix test-child-process-fork-regr-Segfault in node::StreamBase::GetFD #2847 (Santiago Gimeno) #8954
  • [a2621a25e5] - test: remove FIXME pummel/test-tls-securepair-client (Alfred Cepeda) #8757
  • [747013bc39] - test: output tap13 instead of almost-tap (Johan Bergström) #9262
  • [790406661d] - test: refactor test-net-server-max-connections (Rich Trott) #8931
  • [347547a97e] - test: expand test coverage for url.js (Junshu Okamoto) #8859
  • [cec5e36df7] - test: fix test-cluster-worker-init.js flakyness (Ilkka Myller) #8703
  • [b3fccc2536] - test: enable cyrillic punycode test case (Ben Noordhuis) #8695
  • [03f703177f] - test: remove call to net.Socket.resume() (Alfred Cepeda) #8679
  • [527db40932] - test: add coverage for execFileSync() errors (cjihrig) #9211
  • [40ef23969d] - test: writable stream needDrain state (Italo A. Casas) #8799
  • [ba4a3ede56] - test: writable stream ending state (Italo A. Casas) #8707
  • [80a26c7540] - test: writable stream finished state (Italo A. Casas) #8791
  • [a64af39c83] - test: remove duplicate required module (Rich Trott) #9169
  • [a038fcc307] - test: add regression test for instanceof (Franziska Hinkelmann) #9178
  • [bd99b2d4e4] - test: checking if error constructor is assert.AssertionError (larissayvette) #9119
  • [4a6bd8683f] - test: fix flaky test-child-process-fork-dgram (Rich Trott) #9098
  • [d9c33646e6] - test: add regression test for unpipe() (Niels Nielsen) #9171
  • [f9b24f42ba] - test: use npm sandbox in test-npm-install (João Reis) #9079
  • [54c38eb22e] - tickprocessor: apply c++filt manually on mac (Fedor Indutny) #8480
  • [bf25994308] - tls: fix leak of WriteWrap+TLSWrap combination (Fedor Indutny) #9586
  • [9049c1f6b6] - (SEMVER-MINOR) tls: introduce secureContext for tls.connect (Fedor Indutny) #4246
  • [b1bd1c42c0] - tools: allow test.py to use full paths of tests (Francis Gulotta) #9694
  • [533ce48b6a] - tools: make --repeat work with -j in test.py (Rich Trott) #9249
  • [f9baa1119f] - tools: remove dangling eslint symlink (Sam Roberts) #9299
  • [c8dccf29dd] - tools: avoid let in for loops (jessicaquynh) #9049
  • [620cdc5ce8] - tools: fix release script on macOS 10.12 (Evan Lucas) #8824
  • [f18f3b61e3] - util: use template strings (Alejandro Oviedo Garcia) #9120
  • [1dfb5b5a09] - v8: update make-v8.sh to use git (Jaideep Bajwa) #9393
  • [bdb6cf92c7] - win,msi: mark INSTALLDIR property as secure (João Reis) #8795
  • [9a02414a29] - zlib: fix raw inflate with custom dictionary (Tarjei Husøy)

indutny and others added 30 commits November 8, 2016 14:36
Add `secureContext` option to `tls.connect`. It is useful for caching
client certificates, key, and CA certificates.

PR-URL: #4246
Reviewed-By: James M Snell <jasnell@gmail.com>
Originally was h2 should be h3

PR-URL: #9515
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
google build tool gclient doesn't support
svn anymore. Updating v8 build script to use
git instead.

PR-URL: #9393
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Previously, we were relying on the output of gpg from git tag -v to
verify that the key selected by the releaser is the key that was used
to sign the tag. This output can change depending on the version of git
being used. Now, we just check that the output of git tag -v contains
the key selected.

Fixes: #8822
PR-URL: #8824
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #9144
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Fixes: #9309
PR-URL: #9323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
rval never existed, it was added as that in 077f9d7

Fixes: #9001
PR-URL: #9023
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
As the CTC grows and has representation from more time zones, we need to
embrace asynchronous decision making and rely less on the actual
meeting. This change is a proposal for that which, ironically, probably
has to be approved at a meeting.

PR-URL: #8945
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Adds documentation and explicit reasons on why
the GitHub web interface button is not used. This was
explained in the referenced issue by @thealphanerd.

Fixes: #8893
PR-URL: #9044
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Adds verbose reasons to the documentation on why the
Reviewed-By metadata on a pull request is important.
This was loosely mentioned as an issue in the referenced
issue below, and answered by @addaleax.

Ref: #8893
PR-URL: #9044
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Highlight deprecated API methods/properties in "Table of Contents" for
increasing understandability. Adapted code to eslint standards.

PR-URL: #7189
Fixes: nodejs/nodejs.org#772
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
The config.gypi target has a recipe that uses the control function error
to report if the config.gypi file is missing or if it is stale (the
configure file was updated which is a prerequisite of this rule).

GNU make has two phases, immediate and deferred. During the first phase
 it will expand any variables or functions as the makefile is parsed.
The recipe in this case is a shell if statement, which is a deferred
construct. But the control function $(error) is an immediate construct
which will cause the makefile processing to stop during the first phase
of the Make process.

If I understand this correctly the only possible outcome of this rule is
the "Stale config.gypi, please re-run ./configure"  message which will
be done in the first phase and then exit. The shell condition will not
be considered. So it will never report that the config.gypi is missing.

bnoordhuis suggested that we simply change this into a single error
message:
"Missing or stale config.gypi, please run configure"

PR-URL: #9053
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
`end` MUST always be emitted **before** `close`. However, if a handle
will invoke `uv_close_cb` immediately, or in the same JS tick - `close`
may be emitted first.

PR-URL: #9066
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
The documentation erroneously described the errno property as an alias
for the code property, but that is not the case in the implementation.
errno is the error code of the error as a number, and code is the error
code of the error as a string.

PR-URL: #9007
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
npm should run in a sandbox to avoid unwanted interactions. Without
this change, npm would read the userconfig file $HOME/.npmrc which may
contain configs that break this test.

Fixes: #9074
PR-URL: #9079
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #9043

Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #9072
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
At the CTC meeting today, Sakthipriyan noted that there was a link to
the CTC consensus material from the pull request consensus material. The
link was confusing because the CTC consensus material is
meeting-specific, which does not apply to pull requests. I have removed
that link and replaced it with a text explanation.

PR-URL: #9073
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #9070
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Export symbols from the bundled openssl for add-ons to link against.

Fixes: nodejs/node-v0.x-archive#4051
PR-URL: #6274
Reviewed-By: James M Snell <jasnell@gmail.com>
This exports even more openssl symbols when building
on Windows. SSL_set_fd is one example of added symbol.

PR-URL: #7576
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
This is a known de-opt. It may not be 100% necessary in all cases but it
seems like a decent enough idea to avoid it.

Ref: #9553
PR-URL: #8873
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Since 2e568d9 there is a bug where unpiping a stream
from a readable stream that has `_readableState.pipesCount > 1`
will cause it to remove the first stream in the
`_.readableState.pipes` array no matter where in the list the
`dest` stream was.

This patch corrects that problem.

Ref: #9553
PR-URL: #9171
Fixes: #9170
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Since 2e568d9 there is a bug where unpiping a stream
from a readable stream that has `_readableState.pipesCount > 1`
will cause it to remove the first stream in the
`_.readableState.pipes` array no matter where in the list the
`dest` stream was.

Ref: #9553
PR-URL: #9171
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This adds a new ESLint tool to check for let
declarations within the for, forIn, forOf expressions.

Fixes: #9045
Ref: #9553
Ref: #8873
PR-URL: #9049
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
`test-child-process-fork-dgram` is unreliable on some platforms,
especially FreeBSD and AIX within the project's continuous integration
testing. It has also been observed to be flaky on macos.

* Confirm child has received the server before sending packets
* Close the server instance on the parent or child after receiving a

Refs: #8697
Fixes: #8949
Fixes: #8271
PR-URL: #9098
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This http code allows us to provide a fair reason when
we can't return some data to the client by legal issues.

IETF https://datatracker.ietf.org/doc/draft-ietf-httpbis-legally-restricted-status/

Fixes: #4376
PR-URL: #4377
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #9119
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Add regression test for issue
#7592.
The issue was fixed in upstream V8 and this test case was
previously added with a manual cherry pick for v6.x.

Related to: #7638 and
#7592.

PR-URL: #9178
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
`common` is required twice in test-setproctitle.js. Remove one of the
instances.

Other refactoring:

* var -> const and let
* assert.equal -> assert.strictEqual
* assert.notEqual -> assert.notStrickEqual
* string concatenation -> template string
* use of assert.ifError() instead of asserting error is null

PR-URL: #9169
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. v4.x v8 engine Issues and PRs related to the V8 dependency. labels Nov 22, 2016
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Nov 22, 2016

`/bin/sh -c` trick wasn't working for several reasons:

* `/bin/sh -c "..."` expects the first argument after `"..."` to be a
  `$0`, not a `$1`. Previously `-n` wasn't passed to `nm` because of
  this, and many symbols were ordered improperly
* `c++filt` was applied not only to the names of the functions but to
  their `nm` prefixes like `t` and `a` (`t xxx` turns into
  `unsigned char xxx`).

Instead of applying `c++filt` wide and using `sh -c`, execute `nm` as
requested by `deps/v8/tools/tickprocessor.js` and apply `c++filt` to all
matching entries manually.

Included test demonstrates where previous approach failed: all builtins
were merged into `v8::internal::Builtins::~Builtins`, because they were
prefixed by `t` in `nm` output.

PR-URL: #8480
Reviewed-By: Matthew Loring <mattloring@google.com>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
Notable Changes:

Coming Soon

PR-URL: #9736
@MylesBorins
Copy link
Contributor Author

reconbot and others added 4 commits November 26, 2016 16:22
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix

PR-URL: #9694
Fixes: #9684
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

Fixes: #8925
PR-URL: #8938
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Make sure the map allocators are of the same type. This fixes
building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11).

Upstream bug/patch: https://bugs.freebsd.org/208467

PR-URL: #9763
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
test-debug-signal-cluster contains a watchdog timer that results in
false positives in CI. Remove the watchdog timer and let the test runner
determine that the test has timed out.

PR-URL: #9476
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 1, 2016
Notable Changes:

Coming Soon

PR-URL: #9736
@MylesBorins
Copy link
Contributor Author

A couple more commits added to fix BSD 11 and potentially some flaky tests

CI: https://ci.nodejs.org/job/node-test-pull-request/5046/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/461/
rc.2: https://nodejs.org/download/rc/v4.7.0-rc.2/

MylesBorins pushed a commit that referenced this pull request Dec 6, 2016
This LTS release comes with 108 commits. This includes 30 which are doc
related, 28 which are test related, 16 which are build / tool related,
and 4 commits which are updates to dependencies.

Notable Changes:

The SEMVER-MINOR changes include:

* build:
  - export openssl symbols on Windows making it possible to build
    addons linked against the bundled version of openssl (Alex Hultman)
    #7576
* debugger:
  - make listen address configurable in the debugger server
    (Ben Noordhuis) #3316
* dgram:
  - generalized send queue to handle close fixing a potential throw
    when dgram socket is closed in the listening event handler.
    (Matteo Collina) #7066
* http:
  - Introduce the 451 status code "Unavailable For Legal Reasons"
    (Max Barinov) #4377
* tls:
  - introduce `secureContext` for `tls.connect` which is useful for
    caching client certificates, key, and CA certificates.
    (Fedor Indutny) #4246

Notable SEMVER-PATCH changes include:

* build:
  - introduce the configure --shared option for embedders (sxa555)
    #6994
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) #9262
* src:
  - node no longer aborts when c-ares initialization fails
    (Ben Noordhuis) #8710
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    #9586

PR-URL: #9736
@MylesBorins
Copy link
Contributor Author

/cc @nodejs/collaborators this release will be going out today. Can you please put your eyes on the change-log and see if there is anything that looks out of place

This LTS release comes with 108 commits. This includes 30 which are doc
related, 28 which are test related, 16 which are build / tool related,
and 4 commits which are updates to dependencies.

Notable Changes:

The SEMVER-MINOR changes include:

* build:
  - export openssl symbols on Windows making it possible to build
    addons linked against the bundled version of openssl (Alex Hultman)
    #7576
* debugger:
  - make listen address configurable in the debugger server
    (Ben Noordhuis) #3316
* dgram:
  - generalized send queue to handle close fixing a potential throw
    when dgram socket is closed in the listening event handler.
    (Matteo Collina) #7066
* http:
  - Introduce the 451 status code "Unavailable For Legal Reasons"
    (Max Barinov) #4377
* tls:
  - introduce `secureContext` for `tls.connect` which is useful for
    caching client certificates, key, and CA certificates.
    (Fedor Indutny) #4246

Notable SEMVER-PATCH changes include:

* build:
  - introduce the configure --shared option for embedders (sxa555)
    #6994
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) #9262
* src:
  - node no longer aborts when c-ares initialization fails
    (Ben Noordhuis) #8710
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    #9586

PR-URL: #9736
@MylesBorins MylesBorins merged commit 4e73e75 into v4.x Dec 6, 2016
MylesBorins added a commit that referenced this pull request Dec 6, 2016
MylesBorins pushed a commit that referenced this pull request Dec 6, 2016
This LTS release comes with 108 commits. This includes 30 which are doc
related, 28 which are test related, 16 which are build / tool related,
and 4 commits which are updates to dependencies.

Notable Changes:

The SEMVER-MINOR changes include:

* build:
  - export openssl symbols on Windows making it possible to build
    addons linked against the bundled version of openssl (Alex Hultman)
    #7576
* debugger:
  - make listen address configurable in the debugger server
    (Ben Noordhuis) #3316
* dgram:
  - generalized send queue to handle close fixing a potential throw
    when dgram socket is closed in the listening event handler.
    (Matteo Collina) #7066
* http:
  - Introduce the 451 status code "Unavailable For Legal Reasons"
    (Max Barinov) #4377
* tls:
  - introduce `secureContext` for `tls.connect` which is useful for
    caching client certificates, key, and CA certificates.
    (Fedor Indutny) #4246

Notable SEMVER-PATCH changes include:

* build:
  - introduce the configure --shared option for embedders (sxa555)
    #6994
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) #9262
* src:
  - node no longer aborts when c-ares initialization fails
    (Ben Noordhuis) #8710
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    #9586

PR-URL: #9736
imyller added a commit to imyller/meta-nodejs that referenced this pull request Dec 7, 2016
    This LTS release comes with 108 commits. This includes 30 which are doc
    related, 28 which are test related, 16 which are build / tool related,
    and 4 commits which are updates to dependencies.

    Notable Changes:

    The SEMVER-MINOR changes include:

    * build:
      - export openssl symbols on Windows making it possible to build
        addons linked against the bundled version of openssl (Alex Hultman)
        nodejs/node#7576
    * debugger:
      - make listen address configurable in the debugger server
        (Ben Noordhuis) nodejs/node#3316
    * dgram:
      - generalized send queue to handle close fixing a potential throw
        when dgram socket is closed in the listening event handler.
        (Matteo Collina) nodejs/node#7066
    * http:
      - Introduce the 451 status code "Unavailable For Legal Reasons"
        (Max Barinov) nodejs/node#4377
    * tls:
      - introduce `secureContext` for `tls.connect` which is useful for
        caching client certificates, key, and CA certificates.
        (Fedor Indutny) nodejs/node#4246

    Notable SEMVER-PATCH changes include:

    * build:
      - introduce the configure --shared option for embedders (sxa555)
        nodejs/node#6994
    * gtest:
      - the test reporter now outputs tap comments as yamlish
        (Johan Bergstrom) nodejs/node#9262
    * src:
      - node no longer aborts when c-ares initialization fails
        (Ben Noordhuis) nodejs/node#8710
    * tls:
      - fix memory leak when writing data to TLSWrap instance during
        handshake (Fedor Indutny)
        nodejs/node#9586

    PR-URL: nodejs/node#9736

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller added a commit to imyller/meta-nodejs that referenced this pull request Dec 7, 2016
    This LTS release comes with 108 commits. This includes 30 which are doc
    related, 28 which are test related, 16 which are build / tool related,
    and 4 commits which are updates to dependencies.

    Notable Changes:

    The SEMVER-MINOR changes include:

    * build:
      - export openssl symbols on Windows making it possible to build
        addons linked against the bundled version of openssl (Alex Hultman)
        nodejs/node#7576
    * debugger:
      - make listen address configurable in the debugger server
        (Ben Noordhuis) nodejs/node#3316
    * dgram:
      - generalized send queue to handle close fixing a potential throw
        when dgram socket is closed in the listening event handler.
        (Matteo Collina) nodejs/node#7066
    * http:
      - Introduce the 451 status code "Unavailable For Legal Reasons"
        (Max Barinov) nodejs/node#4377
    * tls:
      - introduce `secureContext` for `tls.connect` which is useful for
        caching client certificates, key, and CA certificates.
        (Fedor Indutny) nodejs/node#4246

    Notable SEMVER-PATCH changes include:

    * build:
      - introduce the configure --shared option for embedders (sxa555)
        nodejs/node#6994
    * gtest:
      - the test reporter now outputs tap comments as yamlish
        (Johan Bergstrom) nodejs/node#9262
    * src:
      - node no longer aborts when c-ares initialization fails
        (Ben Noordhuis) nodejs/node#8710
    * tls:
      - fix memory leak when writing data to TLSWrap instance during
        handshake (Fedor Indutny)
        nodejs/node#9586

    PR-URL: nodejs/node#9736

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
hackygolucky pushed a commit to hackygolucky/nodejs.org that referenced this pull request Dec 8, 2016
@MylesBorins MylesBorins deleted the v4.7.0-proposal branch December 15, 2016 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. doc Issues and PRs related to the documentations. lts Issues and PRs related to Long Term Support releases. meta Issues and PRs related to the general management of the project. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.