url: add a got host pattern in url.js #9653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
url
AxelMonroyX
changed the title
|
Maybe Also, it seems your branch has some conflicts. |
|
@mscdex Ready Checklist
Description of changeAdd a hostPattern variable for readable purposes |
jasnell
approved these changes
Nov 18, 2016
|
LGTM |
lpinca
approved these changes
Nov 18, 2016
targos
approved these changes
Nov 19, 2016
|
@AxelMonroyX ... can I ask you to please squash the commits. this is not landing cleanly on master with the merge commit there. |
Add a hostPattern variable for readable purposes
AxelMonroyX
force-pushed
the
add-gott-host-pattern
branch
from
daf841a
to
1b4348a
Compare
|
@jasnell Ready Checklist
Description of changeAdd a hostPattern variable for readable purposes |
jasnell
pushed a commit
that referenced
this pull request
Dec 6, 2016
Add a hostPattern variable for readable purposes PR-URL: #9653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in 1be73e8. Thank you! |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 13, 2016
Add a hostPattern variable for readable purposes PR-URL: #9653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Closing since this has landed. Thanks! |
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
Add a hostPattern variable for readable purposes PR-URL: #9653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Add a hostPattern variable for readable purposes PR-URL: #9653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
Add a hostPattern variable for readable purposes PR-URL: #9653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesDescription of change
Add a hostPattern variable for readable purposes