Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade v8 to 4.1.0.17 #879

Closed
wants to merge 3 commits into from
Closed

deps: upgrade v8 to 4.1.0.17 #879

wants to merge 3 commits into from

Conversation

Cangit
Copy link

@Cangit Cangit commented Feb 18, 2015

@targos
Copy link
Member

targos commented Feb 18, 2015

Why not 4.1.0.17 ?

@Cangit
Copy link
Author

Cangit commented Feb 18, 2015

@targos Initially I did, but I ended up with way more changes in the code than my merged commits indicated. Meaning I could have overwritten some specific io.js v8 hacks or similar, instead of educating myself I just reverted to this- if someone want to educate me I'm all ears.

Edit: Figured it out, I might do this later tonight.

@Cangit
Copy link
Author

Cangit commented Feb 18, 2015

Upgraded to v8 4.1.0.17

@Cangit Cangit changed the title deps: upgrade v8 to 4.1.0.15 deps: upgrade v8 to 4.1.0.17 Feb 18, 2015
@rvagg
Copy link
Member

rvagg commented Feb 19, 2015

If this lands prior to getting 1.3.0 out then I'd like to hold off release for another day to get a nightly out and in the wild.

So my vote would for this to be in 1.3.1 rather than landing in haste I think.

@bnoordhuis
Copy link
Member

@rvagg Agreed.

Tangent: not to slight @Cangit's work but I'd be more comfortable if a TC member does dependency upgrades. The reviewer either has to review the diff very carefully or do the upgrade a second time to check if there are no untoward changes. In both cases, it's more work for what should be a rubber-stamp pull request.

I can update the contributing guide if there is agreement.

@Cangit
Copy link
Author

Cangit commented Feb 19, 2015

Can I suggest giving the responsibility to keep deps updated to a named TC member(?) or give the process some kind of structure to avoid deps not being updated for long periods of time as no one prioritize them over other kinds of work. Perhaps someone that can be able to check every dependency once a week or similar and do the update if necessary.

@mikeal
Copy link
Contributor

mikeal commented Feb 19, 2015

My guess is that not even every TC member is suited to do this. Perhaps we should just have a list of people who "do the v8 upgrades"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants