Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ==, !=, some instances of var, and assert.equal() #8768

Closed
wants to merge 1 commit into from
Closed

replace ==, !=, some instances of var, and assert.equal() #8768

wants to merge 1 commit into from

Conversation

jennabelle
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

Description of change
  • replaced == with ===
  • replaced != with !==
  • replaced some var instances with const
  • replaced assert.equal() with assert.strictEqual()

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 24, 2016
@MylesBorins
Copy link
Contributor

@jennabelle thanks so much for this PR! It would appear that you are going to need to rebase against master as it would appear there is a conflict in test/parallel/test-file-write-stream2.js

@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Sep 24, 2016
@jennabelle jennabelle closed this Sep 25, 2016
@jennabelle
Copy link
Contributor Author

Sorry i messed up. Had to re-do everything --> new pull request #8770 has no base conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants