Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced ==, !=, some var instances, assert.equal() for more clarity #8765

Closed
wants to merge 1 commit into from
Closed

replaced ==, !=, some var instances, assert.equal() for more clarity #8765

wants to merge 1 commit into from

Conversation

jennabelle
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • [ x ] commit message follows commit guidelines
Affected core subsystem(s)

tests

Description of change
  • replaced == with ===
  • replaced != as !==
  • replaced some var instances with const
  • replaced assert.equal() with assert.strictEqual()

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 24, 2016
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Sep 24, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Sep 25, 2016

This needs a rebase due to conflicts in test/parallel/test-file-write-stream2.js.

cjihrig
cjihrig approved these changes Sep 25, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending a rebase and CI run.

@jennabelle jennabelle closed this Sep 25, 2016
@jennabelle
Copy link
Contributor Author

Sorry i messed up. Had to re-do everything --> new pull request #8770 has no base conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jennabelle @cjihrig @mscdex @nodejs-github-bot