New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of https://github.com/nodejs/node/pull/7630 for v4.x #8348

Closed

Trott wants to merge 4 commits into nodejs:v4.x-staging from Trott:v4.x-braces-backport

Member

Trott commented Aug 31, 2016 •

edited

Loading

Backport of #7630 for v4.x

Trott added 4 commits

August 30, 2016 17:16


          doc: add added: info for dgram.*Membership()

3ed2152

Since I was doing the necessary git archaeology anyway, I took the time
to add YAML information to the docs about when `addMembership()` and
`dropMembership()` first appeared in their current forms.

PR-URL: nodejs#6753
Ref: nodejs#6578
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>


          lib: implement consistent brace style

dcf8f46

This change is in preparation for lint-enforced brace style.


          test: implement consistent braces

5cbc604

This change is in preparation for lint enforcement of brace style.


          tools: enforce JS brace style with linting

d1e2db2

Enable `brace-style` in ESLint.

Ref: nodejs#7094 (comment)

Trott assigned MylesBorins

nodejs-github-bot added module net stream labels

Trott mentioned this pull request

Brace style linting #7630

Closed

3 tasks

mscdex added the v4.x label

Trott mentioned this pull request

V4.x backport for tools: increase lint coverage (https://github.com/nodejs/node/pull/7647) #8349

Closed

Member

jasnell commented Aug 31, 2016

LGTM

1 similar comment

Contributor

MylesBorins commented Sep 4, 2016

LGTM

MylesBorins pushed a commit that referenced this pull request


          lib: implement consistent brace style

1c921cc

This change is in preparation for lint-enforced brace style.

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: implement consistent braces

b52571c

This change is in preparation for lint enforcement of brace style.

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          tools: enforce JS brace style with linting

9bddd79

Enable `brace-style` in ESLint.

Ref: #7094 (comment)

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

Contributor

MylesBorins commented Sep 4, 2016

landed in 09099ab...9bddd79

MylesBorins closed this

MylesBorins pushed a commit that referenced this pull request


          lib: implement consistent brace style

f3ae5c5

This change is in preparation for lint-enforced brace style.

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: implement consistent braces

a8cedcb

This change is in preparation for lint enforcement of brace style.

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          tools: enforce JS brace style with linting

fa3ec3d

Enable `brace-style` in ESLint.

Ref: #7094 (comment)

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

rvagg pushed a commit that referenced this pull request


          lib: implement consistent brace style

b7b6c61

This change is in preparation for lint-enforced brace style.

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

rvagg pushed a commit that referenced this pull request


          test: implement consistent braces

ac96980

This change is in preparation for lint enforcement of brace style.

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

rvagg pushed a commit that referenced this pull request


          tools: enforce JS brace style with linting

ab56c05

Enable `brace-style` in ESLint.

Ref: #7094 (comment)

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          lib: implement consistent brace style

f6e332d

This change is in preparation for lint-enforced brace style.

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: implement consistent braces

337d2dd

This change is in preparation for lint enforcement of brace style.

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          tools: enforce JS brace style with linting

d1a50b3

Enable `brace-style` in ESLint.

Ref: #7094 (comment)

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins mentioned this pull request

V4.6.2 proposal #9298

Closed

Trott deleted the v4.x-braces-backport branch

January 13, 2022 22:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module net stream