Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add 2016-08-17 CTC meeting minutes #8245

Merged
merged 1 commit into from
Sep 7, 2016
Merged

doc: add 2016-08-17 CTC meeting minutes #8245

merged 1 commit into from
Sep 7, 2016

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Aug 24, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

add 2016-08-17 CTC meeting minutes

closes #8125

/cc @nodejs/ctc

@joshgav joshgav added the doc Issues and PRs related to the documentations. label Aug 24, 2016
@joshgav joshgav mentioned this pull request Aug 24, 2016
Closed
Trott
Trott reviewed Aug 24, 2016
View reviewed changes
doc/ctc-meetings/2016-08-17.md

@Fishrock123: We should deprecate use without `new`, but deprecating entire constructor isn’t reasonable due to ecosystem usage.

@jasnell: It would be a hard deprecation warning, i.e. throw if used without `new`.
Copy link
Member

@Trott Trott Aug 24, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't quite what @jasnell said. A hard deprecation will only print a warning and not throw unless the command line flag to throw on deprecated functions is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was a bit confused here too. Will try to listen to the audio to clarify or may take out the line entirely if no one's opposed.

@Trott
Copy link
Member

Trott commented Aug 24, 2016

A couple of small notes, and I guess we really ought to note what the conclusion and/or next steps for the Revert "fs: add a temporary..." conversation was...

Otherwise, LGTM.

@joshgav
Copy link
Contributor Author

joshgav commented Aug 24, 2016

@Trott

we really ought to note what the conclusion and/or next steps for the Revert "fs: add a temporary..." conversation was...

The conversation went too fast, I need to go back and listen to the audio, unless someone else can fill in?

@MylesBorins
Copy link
Contributor

this should be revisited @isaacs landed a change into graceful-fs 3 that
fixes all issues regarding re evaluating. this should allow us to move
forward with all outstanding fs changes. I can give a report when I'm back
next week.

On Wed, Aug 24, 2016, 8:00 PM Josh Gavant notifications@github.com wrote:

@Trott https://github.com/Trott

we really ought to note what the conclusion and/or next steps for the
Revert "fs: add a temporary..." conversation was...

The conversation went too fast, I need to go back and listen to the audio,
unless someone else can fill in?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8245 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecVzV6giNfY3ckYHq1JarKLXnZs5jFks5qjKLzgaJpZM4JrmzC
.

@joshgav joshgav force-pushed the ctc-2016-08-17 branch 2 times, most recently from 5d1313b to b0352b5 Compare September 6, 2016 18:17
@joshgav
Copy link
Contributor Author

joshgav commented Sep 6, 2016

Addressed @Trott's comments and added reference to @thealphanerd's comment in the notes. Can I get another LGTM? Thanks!

@jasnell
Copy link
Member

jasnell commented Sep 7, 2016

LGTM

1 similar comment
@Trott
Copy link
Member

Trott commented Sep 7, 2016

LGTM

@joshgav
doc: add 2016-08-17 CTC meeting minutes
c436437 
PR-URL: nodejs#8245
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joshgav joshgav merged commit c436437 into nodejs:master Sep 7, 2016
@joshgav
Copy link
Contributor Author

joshgav commented Sep 7, 2016

landed in c436437

@joshgav joshgav deleted the ctc-2016-08-17 branch September 12, 2016 14:53
Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
@joshgav @Fishrock123
doc: add 2016-08-17 CTC meeting minutes
cffe7b7 
PR-URL: #8245
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@joshgav
doc: add 2016-08-17 CTC meeting minutes
c775e82 
PR-URL: #8245
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@joshgav
doc: add 2016-08-17 CTC meeting minutes
e9d7926 
PR-URL: #8245
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@joshgav @rvagg
doc: add 2016-08-17 CTC meeting minutes
c0aa8a0 
PR-URL: #8245
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@joshgav @MylesBorins
doc: add 2016-08-17 CTC meeting minutes
a7e6fc0 
PR-URL: #8245
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.js Foundation Core Technical Committee (CTC) Meeting 2016-08-17
4 participants
@joshgav @Trott @MylesBorins @jasnell