Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add 2016-08-10 CTC meeting minutes #8229

Merged
merged 1 commit into from
Sep 6, 2016

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Aug 22, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

CTC meeting minutes.

/cc @nodejs/ctc

@joshgav joshgav added the doc Issues and PRs related to the documentations. label Aug 22, 2016
@jasnell
Copy link
Member

jasnell commented Aug 23, 2016

LGTM


Enabling inheritance forces the use of `new`. Thus it will break anyone who uses `Buffer` without the `new` keyword.

@evan: Wasn’t there a way around that?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are going by username, this should be @evanlucas here and on line 147

@evanlucas
Copy link
Contributor

lgtm with a question

@joshgav
Copy link
Contributor Author

joshgav commented Aug 23, 2016

Sorry @evanlucas! Fixed.

Would love suggestions on ideal formatting, such as using identifiers other than GH aliases.


**Next steps**:

* Remove global than land EP.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: than -> then

@mhdawson
Copy link
Member

LGTM

PR-URL: nodejs#8229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@joshgav joshgav merged commit a945244 into nodejs:master Sep 6, 2016
@joshgav
Copy link
Contributor Author

joshgav commented Sep 6, 2016

landed in a945244

@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
PR-URL: nodejs#8229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
PR-URL: #8229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@joshgav joshgav deleted the ctc-2016-08-10 branch September 12, 2016 14:53
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
PR-URL: #8229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
PR-URL: #8229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants