Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add added: information for util #8206

Closed
wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Aug 21, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

@nodejs-github-bot nodejs-github-bot added util Issues and PRs related to the built-in util module. doc Issues and PRs related to the documentations. labels Aug 21, 2016
@@ -125,6 +134,9 @@ util.format(1, 2, 3); // '1 2 3'
```

## util.inherits(constructor, superConstructor)
<!-- YAML
added: v0.3.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is when the module has been renamed. It was called sys before, not sure if it's better to show when the method was added to sys.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think of the added marks as a reference for the user to understand "how far back can I expect this thing to be in this place", so existence elsewhere before then is kind of irrelevant.

@silverwind
Copy link
Contributor

LGTM

3 similar comments
@jasnell
Copy link
Member

jasnell commented Aug 21, 2016

LGTM

@Qard
Copy link
Member

Qard commented Aug 22, 2016

LGTM

@bengl
Copy link
Member

bengl commented Aug 23, 2016

LGTM

jasnell pushed a commit that referenced this pull request Aug 23, 2016
PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@jasnell
Copy link
Member

jasnell commented Aug 23, 2016

Landed in 16f4b8e

@jasnell jasnell closed this Aug 23, 2016
@lpinca lpinca deleted the add/added-util branch August 23, 2016 18:37
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@MylesBorins
Copy link
Contributor

This doesn't land cleanly on v4.x please feel free to manually backport

lpinca added a commit to lpinca/node that referenced this pull request Oct 1, 2016
PR-URL: nodejs#8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins pushed a commit that referenced this pull request Oct 4, 2016
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants