Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: misc changes #8112

Merged
merged 2 commits into from
Aug 23, 2016
Merged

net: misc changes #8112

merged 2 commits into from
Aug 23, 2016

Commits on Aug 23, 2016

  1. net: remove unnecessary variables 

    V8 is smart enough to optimize the length property checking when
iterating over an array with a for loop.

PR-URL: nodejs#8112
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @mscdex
    mscdex committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    d28159f View commit details
    Browse the repository at this point in the history

  2. net: add length check when normalizing args 

    This helps to prevent possible deoptimizations that arise when trying
to access nonexistent indices.

PR-URL: nodejs#8112
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @mscdex
    mscdex committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    a206afe View commit details
    Browse the repository at this point in the history