Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: remove unneeded property #7987

Closed
wants to merge 1 commit into from
Closed

zlib: remove unneeded property #7987

wants to merge 1 commit into from

Conversation

jscissr
Copy link
Contributor

@jscissr jscissr commented Aug 5, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • zlib
Description of change

This property is never used.

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 5, 2016
@yorkie yorkie added the zlib Issues and PRs related to the zlib subsystem. label Aug 5, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Aug 5, 2016

LGTM, pending CI.

@jasnell
Copy link
Member

jasnell commented Aug 5, 2016

/cc @addaleax

@addaleax
Copy link
Member

addaleax commented Aug 5, 2016

LGTM, CI run: https://ci.nodejs.org/job/node-test-commit/4418/

@mscdex
Copy link
Contributor

mscdex commented Aug 5, 2016

LGTM

@jbergstroem
Copy link
Member

LGTM with commit message nit: poperty -> property.

@jscissr jscissr changed the title zlib: remove unneeded poperty zlib: remove unneeded property Aug 5, 2016
@addaleax
Copy link
Member

addaleax commented Aug 8, 2016

Landed in b635f7b, thanks for the PR!

@addaleax addaleax closed this Aug 8, 2016
addaleax pushed a commit that referenced this pull request Aug 8, 2016
@jscissr @addaleax
zlib: remove unneeded property
b635f7b 
PR-URL: #7987
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@jscissr @cjihrig
zlib: remove unneeded property
909254c 
PR-URL: #7987
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
@jscissr jscissr deleted the chunk-size branch August 30, 2017 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jscissr @cjihrig @jasnell @addaleax @mscdex @jbergstroem @yorkie @nodejs-github-bot