lib: remove double check #7985
Closed
lib: remove double check #7985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkIsHttpToken() already checks for typeof string. We do not want to check twice.
|
LGTM |
|
LGTM. CI is green. |
|
LGTM |
|
The commit message should target |
|
LGTM. although this removes an error, it's one that should have already been hidden by the other check, so this wouldn't be a semver-major at all... +1! |
jasnell
pushed a commit
that referenced
this pull request
Aug 8, 2016
checkIsHttpToken() already checks for typeof string. We do not want to check twice. PR-URL: #7985 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 35109dd! |
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
checkIsHttpToken() already checks for typeof string. We do not want to check twice. PR-URL: #7985 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) passesAffected core subsystem(s)
lib
Description of change
checkIsHttpToken() already checks for typeof string. We do not
want to check twice.