Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: support stdio option in fork() #7811

Closed
wants to merge 1 commit into from
Closed

child_process: support stdio option in fork() #7811

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 20, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

child_process

Description of change

This commit allows child_process.fork() to pass stdio options
to spawn(). This allows fork() to more easily take advantage of
additional stdio channels.

Refs: nodejs/node-v0.x-archive#5727

If this is accepted, I'll follow up with a PR for cluster.

@cjihrig
child_process: support stdio option in fork()
b55fd52 
This commit allows child_process.fork() to pass stdio options
to spawn(). This allows fork() to more easily take advantage of
additional stdio channels.
@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Jul 20, 2016
@MylesBorins MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 20, 2016
@MylesBorins
Copy link
Contributor

LGTM

ci: https://ci.nodejs.org/job/node-test-pull-request/3356/

I've gone ahead and marked this semver minor.

@JungMinu
Copy link
Member

CI is happy, LGTM

@santigimeno
Copy link
Member

LGTM

@foo123
Copy link

foo123 commented Jul 21, 2016

Any news on this?

@Fishrock123
Copy link
Contributor

@foo123 PRs usually take a few days to land, especially features.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 22, 2016

Landed in ff3ce11. Follow up PR for cluster coming momentarily.

@cjihrig cjihrig closed this Jul 22, 2016
@cjihrig cjihrig deleted the stdio branch July 22, 2016 16:02
cjihrig added a commit that referenced this pull request Jul 22, 2016
@cjihrig
child_process: support stdio option in fork()
ff3ce11 
This commit allows child_process.fork() to pass stdio options
to spawn(). This allows fork() to more easily take advantage of
additional stdio channels.

Refs: nodejs/node-v0.x-archive#5727
PR-URL: #7811
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@cjihrig cjihrig mentioned this pull request Jul 22, 2016
Merged
4 tasks
cjihrig added a commit to cjihrig/node that referenced this pull request Aug 1, 2016
@cjihrig
cluster: support stdio option for workers
75c6d9d 
This commit allows setupMaster() to configure the stdio channels
for worker processes.

Refs: nodejs/node-v0.x-archive#5727
Refs: nodejs#7811
PR-URL: nodejs#7838
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig added a commit that referenced this pull request Aug 10, 2016
@cjihrig
child_process: support stdio option in fork()
da481c6 
This commit allows child_process.fork() to pass stdio options
to spawn(). This allows fork() to more easily take advantage of
additional stdio channels.

Refs: nodejs/node-v0.x-archive#5727
PR-URL: #7811
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
cjihrig added a commit that referenced this pull request Aug 10, 2016
@cjihrig
cluster: support stdio option for workers
a4f0b13 
This commit allows setupMaster() to configure the stdio channels
for worker processes.

Refs: nodejs/node-v0.x-archive#5727
Refs: #7811
PR-URL: #7838
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
cjihrig added a commit that referenced this pull request Aug 11, 2016
@cjihrig
2016-08-11, Version 6.4.0 (Current)
032ab12 
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942
* repl: The REPL now supports editor mode. (Prince J Wesley) #7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013

Refs: #8020
PR-URL: #8070
cjihrig added a commit that referenced this pull request Aug 11, 2016
@cjihrig
2016-08-11, Version 6.4.0 (Current)
a0a3f93 
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838
* child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) #7696
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942
* repl: The REPL now supports editor mode. (Prince J Wesley) #7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013

Refs: #8020
PR-URL: #8070
cjihrig added a commit that referenced this pull request Aug 15, 2016
@cjihrig
2016-08-15, Version 6.4.0 (Current)
b7eba5e 
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838
* child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) #7696
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942
* repl: The REPL now supports editor mode. (Prince J Wesley) #7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013

Refs: #8020
PR-URL: #8070
cjihrig added a commit to cjihrig/node that referenced this pull request Aug 16, 2016
@cjihrig
2016-08-15, Version 6.4.0 (Current)
d83373d 
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) nodejs#7983 and nodejs#7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) nodejs#7811 and nodejs#7838
* child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) nodejs#7696
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) nodejs#7942
* repl: The REPL now supports editor mode. (Prince J Wesley) nodejs#7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) nodejs#8013

Refs: nodejs#8020
PR-URL: nodejs#8070
@hyj1991 hyj1991 mentioned this pull request Jul 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @MylesBorins @JungMinu @santigimeno @foo123 @Fishrock123 @nodejs-github-bot