deps: cherry-pick 6f68f30 from v8 upstream

[stefanmb]

Checklist

• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

deps

Description of change

Original commit message:

[build] Add force_dynamic_crt option to build a static library with /…
…MD on windows

Adds option to build a V8 library statically, but with the options on
windows that allows it to be subsequently included in another DLL. On
Windows this is required for it to correclty link against the correct
C++ runtime. Require for our Node.js shared library build.

Reference: #7487

BUG=
R=machenbach@chromium.org, michael_dawson@ca.ibm.com

Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d
Review-Url: https://codereview.chromium.org/2149963002
Cr-Original-Commit-Position: refs/heads/master@{#37814}
Cr-Commit-Position: refs/heads/master@{#37856}

[stefanmb]

Required to complete work in #7487
CI: https://ci.nodejs.org/job/node-test-pull-request/3345/

[bnoordhuis]

LGTM. V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/222/

[bnoordhuis]

Node CI again too, previous one failed massively due to network errors: https://ci.nodejs.org/job/node-test-pull-request/3347/

[mhdawson]

LGTM, will land today.

[mhdawson]

Landed as cc18937

[cjihrig]

@stefanmb @mhdawson is this supposed to land in v6? My guess is no, but I wanted to double check.

cc: @nodejs/v8

[stefanmb]

@cjihrig I would say no, since we're not backporting the dependent PR: #7487.

[cjihrig]

OK, thanks. Adding the "don't land on" labels.

[mhdawson]

I'd like it to land on 6.x for our use and I believe other consumers like electron may want that as well.

@sxa555 can you backport #7487. to 6.X so that we have the pre-reqs to land this on 6.x

I think we should hold off on 4.x until we have testing etc. in place, but I do think we want in the next LTS to go out.

I'll remove the dont-land-on-v6.x, let me know if anybody disagress.

[cjihrig]

I'm going to reapply the dont-land-on-v6.x label, because this doesn't apply cleanly. We can use a backport PR instead.

[ofrobots]

I have included this commit in #8054. This won't need independent backporting if that lands on v6.x.

[sxa]

@cjihrig I believe the only issue with the application was that the V8 version numbers were different. The modifications themselves apply ok :-) I'm creating a separate PR that will do this along with the main WIndows changes to build as a DLL (although I can take that out if the 5.1 update lands quickly as @ofrobots suggests).

[MylesBorins]

why did this backport move the change from common.gypi to toolchain.gypi?