cluster: remove bind() and self #7710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
cluster
|
R= @santigimeno ? |
|
LGTM |
|
LGTM if CI is happy: https://ci.nodejs.org/job/node-test-pull-request/3295/ |
|
LGTM |
This commit removes the use of self and bind() from the cluster module in favor of arrow functions. PR-URL: nodejs#7710 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jul 19, 2016
This commit removes the use of self and bind() from the cluster module in favor of arrow functions. PR-URL: #7710 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jul 20, 2016
This commit removes the use of self and bind() from the cluster module in favor of arrow functions. PR-URL: #7710 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
|
@cjihrig I've backported this to v4.x. Do you know if there are any performance issues with arrow function in V8 4.8? /cc @nodejs/v8 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
This commit removes the use of self and bind() from the cluster module in favor of arrow functions. PR-URL: #7710 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
|
Nothing comes to mind. I don't recall the project ever holding back on the use of arrow functions for performance reasons. |
|
@cjihrig sgtm. Just being extraaaa careful 😄 |
|
What is the motivation to backport to |
|
@ofrobots trying to keep the delta in cluster as small as possible. This is only to staging and can easily be removed if you don't think it should land. |
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
This commit removes the use of self and bind() from the cluster module in favor of arrow functions. PR-URL: #7710 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
This commit removes the use of self and bind() from the cluster module in favor of arrow functions. PR-URL: #7710 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
cluster
Description of change
This commit removes the use of
selfandbind()from theclustermodule in favor of arrow functions.