Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: don't use locale-sensitive strcasecmp() (v4.x) #7660

Closed
wants to merge 2 commits into from
Closed

src: don't use locale-sensitive strcasecmp() (v4.x) #7660

wants to merge 2 commits into from

Commits on Jul 11, 2016

  1. src: remove unused #include statement 

    strcasecmp() is not used in src/node_http_parser.cc so there is no need
to include its header file.

PR-URL: nodejs#6582
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    9a875d1 View commit details
    Browse the repository at this point in the history

  2. src: don't use locale-sensitive strcasecmp() 

    strcasecmp() is affected by the current locale as configured through
e.g. the LC_ALL environment variable and the setlocale() libc function.

It can result in unpredictable results across systems so replace it with
a function that isn't susceptible to that.

PR-URL: nodejs#6582
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    aa8c48f View commit details
    Browse the repository at this point in the history